From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Robert Haas <robertmhaas@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Amit Kapila <amit.kapila16@gmail.com>
Subject: Re: Why are we PageInit'ing buffers in RelationAddExtraBlocks()?
In-reply-to: <20190128222259.zhi7ovzgtkft6em6@alap3.anarazel.de>
References: 
 <CA+TgmoZRwKbf6q7TXEpwMX_vdjfeGEKudR8mofnmTwZg6O9=kg@mail.gmail.com>
 <20181219223736.4k2lhqoj34aaxj3m@alap3.anarazel.de>
 <CA+TgmoaJ67VCefuhkd0fdJiWb64bqBtkbZazbVm6a0wimY0fRQ@mail.gmail.com>
 <13071.1545266373@sss.pgh.pa.us>
 <20181220005636.cowkudhiu666mhdi@alap3.anarazel.de>
 <20181220230411.zzwioucrg7d3ld2m@alap3.anarazel.de>
 <20190115204428.kpqmk3ix6cenr7gi@alap3.anarazel.de>
 <11587.1547591721@sss.pgh.pa.us>
 <20190128213346.ie6zbwiddgnfd37l@alap3.anarazel.de>
 <20190128221055.nddkrusu3u5263qo@alap3.anarazel.de>
 <20190128222259.zhi7ovzgtkft6em6@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 28 Jan 2019 14:22:59 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <26262.1548716938.1@sss.pgh.pa.us>
Date: Mon, 28 Jan 2019 18:08:59 -0500
Message-ID: <26263.1548716939@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> I'm inclined to put back the
>            LockBuffer(buf, BUFFER_LOCK_UNLOCK);
>            LockRelationForExtension(onerel, ExclusiveLock);
>            UnlockRelationForExtension(onerel, ExclusiveLock);
>            LockBufferForCleanup(buf);
>            if (PageIsNew(page))
> dance regardless, just to get the buildfarm to green?

The buildfarm's got half a dozen reports now of a failure of this ilk,
so you'd better do something.

> But I do wonder if we should just make hio.c cope with this instead.

Probably should not try to go that way under time presssure.

			regards, tom lane