From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Noah Misch <noah@leadboat.com>, Thomas Munro <thomas.munro@gmail.com>,
        Vik Fearing <vik@postgresfriends.org>,
 cary huang <hcary328@gmail.com>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Add support for AT LOCAL
In-reply-to: <ZS3GaSuqwi_TauDQ@paquier.xyz>
References: 
 <CA+hUKGLYaVJ7df+Uu=ctUunRcqUsGY55feVQa-1pzz1=PT=z3w@mail.gmail.com>
 <2188264.1697425365@sss.pgh.pa.us>
 <CA+hUKGJSEOVonGsYCiuhZXsBFCxXtjNyHGYvn-w9jykGo2PgqQ@mail.gmail.com>
 <2191749.1697427017@sss.pgh.pa.us> <20231016045804.c0@rfd.leadboat.com>
 <20231016055051.3a@rfd.leadboat.com> <2208907.1697435663@sss.pgh.pa.us>
 <20231016060510.72@rfd.leadboat.com> <ZSzmdDenWESX5jmW@paquier.xyz>
 <2287835.1697464481@sss.pgh.pa.us> <ZS3GaSuqwi_TauDQ@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Tue, 17 Oct 2023 08:25:29 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2631003.1697508701.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 16 Oct 2023 22:11:41 -0400
Message-ID: <2631004.1697508701@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2631004.1697508701%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Oct 16, 2023 at 09:54:41AM -0400, Tom Lane wrote:
>> I'm mighty tempted though to (a) add coverage for timetz_izone
>> to HEAD, and (b) backpatch the new tests, sans the AT LOCAL case,
>> to the back branches (maybe not v11).

> I see that you've already done (a) with 2f04720307.  I'd be curious to
> see what happens for (b), as well, once (a) is processed on hornet
> once..

Sure enough, timetz_izone has exactly the same behavior [1].

I'd kind of decided that back-patching wouldn't be worth the trouble;
do you foresee that it'd teach us anything new?

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dhornet&dt=3D=
2023-10-17%2000%3A07%3A36