Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ec3zL-0001RR-Cd for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Jan 2018 06:47:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ec3zK-0005Ff-Mm for pgsql-hackers@arkaria.postgresql.org; Thu, 18 Jan 2018 06:47:50 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ec3zK-0005FW-DC for pgsql-hackers@lists.postgresql.org; Thu, 18 Jan 2018 06:47:50 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ec3zH-0003fz-VF for pgsql-hackers@lists.postgresql.org; Thu, 18 Jan 2018 06:47:49 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w0I6lkUC026313; Thu, 18 Jan 2018 01:47:46 -0500 From: Tom Lane To: Victor Wagner cc: pgsql-hackers@lists.postgresql.org Subject: Re: master make check fails on Solaris 10 In-reply-to: <20180118094049.10293b39@fafnir.local.vm> References: <0d3a9fa264cebe1cb9966f37b7c06e86@postgrespro.ru> <20180111173938.jimybeayp2u5mmup@alap3.anarazel.de> <31a342fa6a025a8bdfc5b8b19c29d56d@postgrespro.ru> <1232.1515780057@sss.pgh.pa.us> <15299.1515867055@sss.pgh.pa.us> <18209.1516059711@sss.pgh.pa.us> <90ab676392c8f9c84431976147097cf0@postgrespro.ru> <17897.1516202926@sss.pgh.pa.us> <1c70bab595a37ffa3a7fafea29fa6f55@postgrespro.ru> <31743.1516206789@sss.pgh.pa.us> <20180118094049.10293b39@fafnir.local.vm> Comments: In-reply-to Victor Wagner message dated "Thu, 18 Jan 2018 09:40:49 +0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <26311.1516258066.1@sss.pgh.pa.us> Date: Thu, 18 Jan 2018 01:47:46 -0500 Message-ID: <26312.1516258066@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Victor Wagner writes: > Tom Lane wrote: >> Attached is a draft patch to incorporate Victor's slimmed-down test >> into configure. If you have a chance, could you confirm it does >> the right thing on your Sparc machine? > It seems that what it does is not exactly a right thing. > I've applied it to commit 9c7d06d60680 in master and see following > checking for __int128 alignment bug... ok > As far as I understand your patch, there should be: > checking for __int128 alignment bug... broken Yes, that's what I expected to happen. > Then in the pg_config.h I see > /* The normal alignment of `PG_INT128_TYPE', in bytes. */ > #define ALIGNOF_PG_INT128_TYPE 16 > /* Define to the name of a signed 128-bit integer type. */ > #define PG_INT128_TYPE __int128 That's what I'd expect if configure thinks all's well :-( > However, make check passes. Uh ... how could that be? If the output of configure is exactly the same as before the patch, how could the end result be different? > We, Marina and I would continue investigation. I look forward to some results ... but I'm going to bed now ... regards, tom lane