To: Andrew Dunstan <andrew@dunslane.net>
cc: Peter Eisentraut <peter_e@gmx.net>,
	Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: foreign_data test fails with non-C locale 
In-reply-to: <49676B8A.8020707@dunslane.net> 
References: <49675B3F.20002@enterprisedb.com> <49675C87.8070303@dunslane.net>
	<49675E4E.1080805@gmx.net> <49676B8A.8020707@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Fri, 09 Jan 2009 10:21:46 -0500"
Date: Fri, 09 Jan 2009 11:24:55 -0500
Message-ID: <26314.1231518295@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

Andrew Dunstan <andrew@dunslane.net> writes:
> Peter Eisentraut wrote:
>> The regression tests should work just fine in non-C locales.

> It was discussed here at the time, IIRC, and we put in the check 
> precisely because other locales broke the buildfarm. Originally 
> buildfarm just inherited the locale from its environment.

I don't think we are prepared to buy into a general policy that the
regression tests should pass in *any* locale; maintaining a large
number of variant expected-files isn't very practical.  However, the
de facto policy is that we try to keep them passing in locales that
are used by any of the regular developers.  I think it would be useful
to have buildfarm members testing in a few common locales.

			regards, tom lane