Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fDxwx-00024J-6G
	for pgsql-hackers@arkaria.postgresql.org; Wed, 02 May 2018 20:02:03 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fDxwv-00055u-75
	for pgsql-hackers@arkaria.postgresql.org; Wed, 02 May 2018 20:02:01 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fDxwv-00055k-04
	for pgsql-hackers@lists.postgresql.org; Wed, 02 May 2018 20:02:01 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fDxws-0007RB-DE
	for pgsql-hackers@postgresql.org; Wed, 02 May 2018 20:02:00 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w42K1r9v026335;
	Wed, 2 May 2018 16:01:53 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
cc: Michael Paquier <michael@paquier.xyz>,
        Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: A few warnings on Windows
In-reply-to: 
 <CAEepm=05qF_Sq80oVsk53mvCO3KNSVK8Dt5VCnB5LHkQjh9ejQ@mail.gmail.com>
References: 
 <CAEepm=3=TDYEXUEcHpEx+Twc31wo7PA0oBAiNt6sWmq93MW02A@mail.gmail.com>
 <20180501083026.GB25848@paquier.xyz> <15083.1525207729@sss.pgh.pa.us>
 <CAEepm=2AQxJENLfhZzU-=AcxmHXbDXV=kEdzPh7hjQrmmuHxWQ@mail.gmail.com>
 <CAEepm=3Q9y5mUcheKZ2jC9yFn8jb9Z-5vF03WE0mPD-JskSZVQ@mail.gmail.com>
 <26880.1525217953@sss.pgh.pa.us>
 <CAEepm=1vo7zUaAvHcRnLieNQ2rbqDDoyjDXxWxJF_aUfWCY8Lg@mail.gmail.com>
 <CAEepm=0xscPGb=VORui=ikec5OJ17t4hJG5KjEJk7B2+wUAJXA@mail.gmail.com>
 <18264.1525235334@sss.pgh.pa.us>
 <CAEepm=05qF_Sq80oVsk53mvCO3KNSVK8Dt5VCnB5LHkQjh9ejQ@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@enterprisedb.com>
	message dated "Wed, 02 May 2018 17:41:32 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <26333.1525291313.1@sss.pgh.pa.us>
Date: Wed, 02 May 2018 16:01:53 -0400
Message-ID: <26334.1525291313@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Thomas Munro <thomas.munro@enterprisedb.com> writes:
> The only remaining warnings on those machines now come from the fact
> that our port_win32.h and Perl's XSUB.h both want to define macros to
> define macros for libc functions like mkdir etc.  plperl.h already
> seems to deal with other similar kinds of ugliness.  Perhaps if
> PG_NEED_PERL_XSUB_H is defined we should undefine port_win32.h's
> libc-stealing macros before including it?  Either way XSUB.h's
> definitions win.  That should get us to 0 warnings.  See attached (not
> tested).

Seems reasonable to me.  Pushed, we'll see what the buildfarm thinks.

			regards, tom lane