From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavan Deolasee <pavan.deolasee@gmail.com>
cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Failure in commit_ts tap tests
In-reply-to: 
 <CABOikdMLJnn4ZvrP055TjuqH=+d+muCfY6i-O8+_34FPQutrAQ@mail.gmail.com>
References: <20170120182702.tjjk2mh3t5keansh@alvherre.pgsql>
 <21212.1484939708@sss.pgh.pa.us>
 <CABOikdMLJnn4ZvrP055TjuqH=+d+muCfY6i-O8+_34FPQutrAQ@mail.gmail.com>
Comments: In-reply-to Pavan Deolasee <pavan.deolasee@gmail.com>
	message dated "Sat, 21 Jan 2017 11:10:48 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <26338.1485013196.1@sss.pgh.pa.us>
Date: Sat, 21 Jan 2017 10:39:56 -0500
Message-ID: <26339.1485013196@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Pavan Deolasee <pavan.deolasee@gmail.com> writes:
> I think I understand why it's only affecting me and not others.
> I've PGDATESTYLE set to "Postgres, MDY" in my bashrc and that formats the
> commit timestamp as "Fri Jan 20 07:59:52.322811 2017 PST". If I unset that,
> the result comes in a format such as  "2017-01-20 21:31:47.766371-08".
> Looks like perl doesn't throw an error if it can parse the leading part of
> the string as a numeric. It still throws a warning, but the test passes.

Hm, but what of the "null" value?  Also, I get

$ perl -e 'use warnings; use Test::More; ok("2017-01-01" != "null", "ok");'
Argument "null" isn't numeric in numeric ne (!=) at -e line 1.
Argument "2017-01-01" isn't numeric in numeric ne (!=) at -e line 1.
ok 1 - ok
# Tests were run but no plan was declared and done_testing() was not seen.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers