From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Andres Freund <andres@anarazel.de>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        James Coleman <jtc331@gmail.com>,
        pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
        Simon Riggs <simon@2ndquadrant.com>
Subject: Re: PROC_IN_ANALYZE stillborn 13 years ago
In-reply-to: 
 <CA+Tgmob0veNwAikDiuWTHcTpQHdqAHFqqgf9ycg9dZyiWR30eg@mail.gmail.com>
References: <20200805021435.GA9523@alvherre.pgsql>
 <20200805235549.GA8118@alvherre.pgsql>
 <20200806010711.mzvu36zy25xer33t@alap3.anarazel.de>
 <CA+TgmoZn5oX4j3KXMkQx=RN+QBgc_y3+1LjBcy_afOmJb-f0-A@mail.gmail.com>
 <2637311.1596739058@sss.pgh.pa.us>
 <CA+Tgmob0veNwAikDiuWTHcTpQHdqAHFqqgf9ycg9dZyiWR30eg@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Thu, 06 Aug 2020 14:48:52 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2638832.1596741087.1@sss.pgh.pa.us>
Date: Thu, 06 Aug 2020 15:11:27 -0400
Message-ID: <2638833.1596741087@sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> Not to get too far from the proposal on the table of just removing
> something that's been unused for a really long time, which stands on
> its own merits, but if a particular ANALYZE doesn't invoke any
> user-defined functions and isn't run inside a transaction, could we
> skip acquiring a snapshot altogether? That's an extremely common case,
> though by no means universal.

I'm inclined to think not.

(1) Without a snapshot it's hard to make any non-bogus decisions about
which tuples are live and which are dead.  Admittedly, with Simon's
proposal the final totals would be spongy anyhow, but at least the
individual decisions produce meaningful answers.

(2) I'm pretty sure there are places in the system that assume that any
reader of a table is using an MVCC snapshot.  For instance, didn't you
introduce some such assumptions along with or just after getting rid of
SnapshotNow for catalog scans?

			regards, tom lane