From: Tom Lane <tgl@sss.pgh.pa.us>
To: Craig Ringer <craig@2ndquadrant.com>
cc: Michael Paquier <michael.paquier@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
        Manuel Kniep <m.kniep@web.de>,
        "fujita.etsuro@lab.ntt.co.jp" <fujita.etsuro@lab.ntt.co.jp>
Subject: Re: PATCH: Batch/pipelining support for libpq
In-reply-to: 
 <CAMsr+YGY7CO8+vWBqFfdYLqzrZSpcKHc-AVWSu25_++kek-Ecw@mail.gmail.com>
References: 
 <CAMsr+YFUjJytRyV4J-16bEoiZyH=4nj+sQ7JP9ajwz=B4dMMZw@mail.gmail.com>
 <20160523155002.debxru4u57tqztyy@alap3.anarazel.de>
 <CAB7nPqQgXamo_XEV37ZvfSO3Od-jtgyXdRAGfy251+AFsjNwig@mail.gmail.com>
 <CAMsr+YGY7CO8+vWBqFfdYLqzrZSpcKHc-AVWSu25_++kek-Ecw@mail.gmail.com>
Comments: In-reply-to Craig Ringer <craig@2ndquadrant.com>
	message dated "Tue, 24 May 2016 12:02:15 +0800"
Date: Tue, 24 May 2016 00:28:40 -0400
Message-ID: <2644.1464064120@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Craig Ringer <craig@2ndquadrant.com> writes:
> On 24 May 2016 at 00:00, Michael Paquier <michael.paquier@gmail.com> wrote:
>> Did you consider the use of simple_list.c instead of introducing a new
>> mimic as PGcommandQueueEntry? It would be cool avoiding adding new
>> list emulations on frontends.

> I'd have to extend simple_list to add a generic object version, like

> struct my_list_elem
> {
>     PG_SIMPLE_LIST_ATTRS;
>     mytype mycol;
>     myothertype myothercol;
> }

> Objections?

That doesn't look exactly "generic".

> I could add a void* version that's a simple clone of the string version,
> but having to malloc both a list cell and its contents separately is
> annoying.

I'd be okay with a void* version, but I'm not sure about this.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers