public inbox for [email protected]  
help / color / mirror / Atom feed
From: Tom Lane <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Shinya Kato <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Use pg_current_xact_id() instead of deprecated txid_current()
Date: Sun, 08 Feb 2026 11:24:44 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAOzEurQetW=-1+OnMo8baeVQF=-kAr-wNtFcgRNo+ErPk=xsDQ@mail.gmail.com>
	<[email protected]>

=?UTF-8?Q?=C3=81lvaro_Herrera?= <[email protected]> writes:
> On 2026-02-08, Shinya Kato wrote:
>> Since pg_current_xact_id() returns xid8 which does not support
>> arithmetic operators, places that need "xid + 1" cast the result via
>> ::text::bigint first.

> I think it may be better to add some operators, or was there a rationale for these not being there?

I'm fairly concerned about overloading the arithmetic operators with
unsigned versions.  The reason we never invented SQL-level uint8 and
such is fear of getting a lot of "ambiguous operator" errors.  Now,
if we are careful not to create implicit casts between xid[8] and
any ordinary type, maybe it'd be okay to invent xid+int, xid8-int,
and a few more.

As things stand, I don't find the proposed patch to be an improvement.

			regards, tom lane






reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Use pg_current_xact_id() instead of deprecated txid_current()
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox