Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZ6DN-0007Er-Qr for pgsql-hackers@arkaria.postgresql.org; Fri, 16 Sep 2022 07:56:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oZ6DM-0003v8-Oi for pgsql-hackers@arkaria.postgresql.org; Fri, 16 Sep 2022 07:56:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZ6DL-0003uz-OT for pgsql-hackers@lists.postgresql.org; Fri, 16 Sep 2022 07:56:44 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZ6DH-00057C-HS for pgsql-hackers@postgresql.org; Fri, 16 Sep 2022 07:56:43 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 0087C5C0206; Fri, 16 Sep 2022 03:56:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 16 Sep 2022 03:56:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663314995; x= 1663401395; bh=8fNF76EQvzCeXUOv93mQPjamye41zrUOL8xj9tLb7p4=; b=m o1FfWt7/ClJmfREgfnPOrFJ0c4g38WDhBELJhCnd3B7MltWaU6W6lu8DixPyU9B4 efUEtE4v2/tBq+4cHD149fiAahCqgZhiMH+17yAMUEdW2dwhbdkOnUjPtiKamHOf LRiTqdgd97GjU5aueBHXwsw8B3IBaLcg0XdiMKtdpSrG4RL73Dq0/cNkIlt4jfBj 8EGngAjG2J9rEzSQ+Zgu9r0llR0uBFzohuiJn5WubmMJIAFi4dMRwbIvvyaEi2Yn xSGmzFrJSpR/Z6fIobELGvJqnbDFOD+frTdIIShwcox+sf/qjEmQ+iIkfd8sqM5J TjAWYgMafvX35hJEIcEQg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduledguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomheprfgv thgvrhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsegvnh htvghrphhrihhsvggusgdrtghomheqnecuggftrfgrthhtvghrnhepheelffeggedujeet iefhleetuddvieffhfffvdejvdffgeejkeduleduheduieefnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgr uhhtsegvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Sep 2022 03:56:33 -0400 (EDT) Message-ID: <26461c69-cbce-c286-1716-41148b5e0f06@enterprisedb.com> Date: Fri, 16 Sep 2022 09:56:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: ICU for global collation Content-Language: en-US To: Marina Polyakova , Kyotaro Horiguchi Cc: pgsql-hackers@postgresql.org, pryzby@telsasoft.com, rjuju123@gmail.com, daniel@manitou-mail.org, AndrewBille@gmail.com, michael@paquier.xyz References: <1f86f120-7b02-68f6-a434-132d054afe33@enterprisedb.com> <38d2aac40a991b20adf032e509c6eff5@postgrespro.ru> <6dd6db0984d86a51b7255ba79f111971@postgrespro.ru> <20220915.155210.529619933474389138.horikyota.ntt@gmail.com> <2322791a368e9ad066edd648790b5e91@postgrespro.ru> From: Peter Eisentraut In-Reply-To: <2322791a368e9ad066edd648790b5e91@postgrespro.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 15.09.22 17:41, Marina Polyakova wrote: > I agree with you. Here's another version of the patch. The > locale/encoding checks and reports in initdb have been reordered, > because now the encoding is set first and only then the ICU locale is > checked. I committed something based on the first version of your patch. This reordering of the messages here was a little too much surgery for me at this point. For instance, there are also messages in #ifdef WIN32 code that would need to be reordered as well. I kept the overall structure of the code the same and just inserted the additional proposed checks. If you want to pursue the reordering of the checks and messages overall, a patch for the master branch could be considered.