From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ronan Dunklau <ronan.dunklau@aiven.io>
cc: pgsql-hackers@lists.postgresql.org,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: Converting contrib SQL functions to new style
In-reply-to: <3316564.aeNJFYEL58@aivenlaptop>
References: <3395418.1618352794@sss.pgh.pa.us>
 <icwj06MeNjimdlNmL6h9X5bmqwe0QngwSOzunFna3RS9fYIxyAFMi7UG7hOp4CQTmFEHDkdhG3z9iBpXHBwNOA==@protonmail.internalid>
 <2102171.1630517255@sss.pgh.pa.us> <3316564.aeNJFYEL58@aivenlaptop>
Comments: In-reply-to Ronan Dunklau <ronan.dunklau@aiven.io>
	message dated "Tue, 29 Oct 2024 08:28:55 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <2650822.1730736601.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 04 Nov 2024 11:10:01 -0500
Message-ID: <2650823.1730736601@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2650823.1730736601%40sss.pgh.pa.us>
Precedence: bulk

Ronan Dunklau <ronan.dunklau@aiven.io> writes:
> Le mercredi 1 septembre 2021, 19:27:35 heure normale d=E2=80=99Europe ce=
ntrale Tom =

> Lane a =C3=A9crit :
>> The rest of this is stuck pending investigation of the ideas about
>> making new-style function creation safer when the creation-time path
>> isn't secure, so I suppose we should mark it RWF rather than leaving
>> it in the queue.  Will go do that.

> Sorry to revive such an old thread but ... since the introduction of the=
 =

> @extschema:name@ syntax in 72a5b1fc880481914da2d4233077438dd87840ca we c=
an now =

> proceed with this or am I missing something ?

Yeah, seems like we could make it work with that.

> I've updated the previous patches to convert them to the new-style, adde=
d one =

> for lo as well.

The cfbot says many of these fail regression tests --- lots of

 CREATE EXTENSION citext SCHEMA s;
+ERROR:  extension "citext" has no installation script nor update path for=
 version "1.8"

and such.  I didn't poke into why, but maybe you missed "git add'ing"
some changes?

			regards, tom lane