From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Jonathan S. Katz" <jkatz@postgresql.org>
cc: Noah Misch <noah@leadboat.com>, Robert Haas <robertmhaas@gmail.com>,
        Andrew Dunstan <andrew@dunslane.net>,
 Bruce Momjian <bruce@momjian.us>,
        Michael Paquier <michael@paquier.xyz>,
        Justin Pryzby <pryzby@telsasoft.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Shruthi Gowda <gowdashru@gmail.com>
Subject: Re: pg15b2: large objects lost on upgrade
In-reply-to: <635c8809-3525-7dae-a1a1-0d9069cd86bc@postgresql.org>
References: <YuCQQtF2p3qWs7t+@momjian.us>
 <CA+Tgmob6_NTj-euMShhcnAB_=CnkRO7-UgXVfWs4fACuDk8uAA@mail.gmail.com>
 <3901843.1659116952@sss.pgh.pa.us>
 <CA+TgmobzCRWG=_Tf0VXvF26pZbTxV-CKPNx6RdoWonKPETLvyQ@mail.gmail.com>
 <CA+TgmoYKVbB9rt2UAvaFLG-qYCgRuhAr7wPLDwTT0VpbPKvj_w@mail.gmail.com>
 <CA+TgmoZiBP2OD9POF0R2L=fib4ueOUusSVzmnO0_+kNzqSpnKw@mail.gmail.com>
 <4152163.1659124804@sss.pgh.pa.us>
 <CA+TgmoY=MfT2uc=N!4sAcHf3_teqYBNtmqVrVYv5oEK=4RfxATw@mail.gmail.com>
 <CA+TgmoZX6Zz4KU2enOYyc+aQWA+S5ZaZRGo6BgxW7mNF4btqaw@mail.gmail.com>
 <125444.1659136594@sss.pgh.pa.us> <20220730054401.GB3644221@rfd.leadboat.com>
 <351616.1659192034@sss.pgh.pa.us>
 <635c8809-3525-7dae-a1a1-0d9069cd86bc@postgresql.org>
Comments: In-reply-to "Jonathan S. Katz" <jkatz@postgresql.org>
	message dated "Mon, 01 Aug 2022 17:17:53 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2657258.1659460333.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 02 Aug 2022 13:12:13 -0400
Message-ID: <2657259.1659460333@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2657259.1659460333%40sss.pgh.pa.us>
Precedence: bulk

"Jonathan S. Katz" <jkatz@postgresql.org> writes:
> Given this appears to be resolved, I have removed this from "Open =

> Items". Thanks!

Sadly, we're still not out of the woods.  I see three buildfarm
failures in this test since Robert resolved the "-X" problem [1][2][3]:

grassquit reported

[19:34:15.249](0.001s) not ok 14 - old and new horizons match after pg_upg=
rade
[19:34:15.249](0.001s) =

[19:34:15.249](0.000s) #   Failed test 'old and new horizons match after p=
g_upgrade'
#   at t/002_pg_upgrade.pl line 336.
=3D=3D=3D diff of /mnt/resource/bf/build/grassquit/REL_15_STABLE/pgsql.bui=
ld/src/bin/pg_upgrade/tmp_check/tmp_test_z3zV/horizon1.txt and /mnt/resour=
ce/bf/build/grassquit/REL_15_STABLE/pgsql.build/src/bin/pg_upgrade/tmp_che=
ck/tmp_test_z3zV/horizon2.txt
=3D=3D=3D stdout =3D=3D=3D
785c785
< spgist_point_tbl|7213|1
---
> spgist_point_tbl|7356|3
787c787
< spgist_text_tbl|7327|1
---
> spgist_text_tbl|8311|3=3D=3D=3D stderr =3D=3D=3D
=3D=3D=3D EOF =3D=3D=3D

wrasse reported

[06:36:35.834](0.001s) not ok 14 - old and new horizons match after pg_upg=
rade
[06:36:35.835](0.001s) =

[06:36:35.835](0.000s) #   Failed test 'old and new horizons match after p=
g_upgrade'
#   at t/002_pg_upgrade.pl line 336.
=3D=3D=3D diff of /export/home/nm/farm/studio64v12_6/REL_15_STABLE/pgsql.b=
uild/src/bin/pg_upgrade/tmp_check/tmp_test_mLle/horizon1.txt and /export/h=
ome/nm/farm/studio64v12_6/REL_15_STABLE/pgsql.build/src/bin/pg_upgrade/tmp=
_check/tmp_test_mLle/horizon2.txt
=3D=3D=3D stdout =3D=3D=3D
138c138
< delete_test_table|7171|1
---
> delete_test_table|7171|3=3D=3D=3D stderr =3D=3D=3D
Warning: missing newline at end of file /export/home/nm/farm/studio64v12_6=
/REL_15_STABLE/pgsql.build/src/bin/pg_upgrade/tmp_check/tmp_test_mLle/hori=
zon1.txt
Warning: missing newline at end of file /export/home/nm/farm/studio64v12_6=
/REL_15_STABLE/pgsql.build/src/bin/pg_upgrade/tmp_check/tmp_test_mLle/hori=
zon2.txt=3D=3D=3D EOF =3D=3D=3D

conchuela doesn't seem to have preserved the detailed log, but it
failed at the same place:

#   Failed test 'old and new horizons match after pg_upgrade'
#   at t/002_pg_upgrade.pl line 336.

Not sure what to make of this, except that maybe the test is telling
us about an actual bug of exactly the kind it's designed to expose.

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dgrassquit&dt=
=3D2022-08-01%2019%3A25%3A43
[2] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dwrasse&dt=3D=
2022-08-02%2004%3A18%3A18
[3] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dconchuela&dt=
=3D2022-08-02%2014%3A56%3A49