public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Alexander Lakhin <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: Rethinking the implementation of ts_headline()
Date: Thu, 06 Apr 2023 15:55:58 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<[email protected]>
Alexander Lakhin <[email protected]> writes:
> I've found that starting from commit 5a617d75 this query:
> SELECT ts_headline('english', 'To be, or not to be', to_tsquery('english', 'or'));
> invokes a valgrind-detected error:
> ==00:00:00:03.950 3241424== Invalid read of size 1
On my machine, I also see PG-reported errors such as "unrecognized
operator: 0". It's a live bug all right. We need to be more careful
about empty tsqueries.
> But the less-verbose call:
> SELECT ts_headline('', '');
> discovers a different error even on 5a617d75~1:
> ==00:00:00:04.113 3139158== Conditional jump or move depends on uninitialised value(s)
> ==00:00:00:04.113 3139158== at 0x77B44F: mark_fragment (wparser_def.c:2100)
Yeah, this one seems to be ancient sloppiness. I don't think it has
any bad effect beyond annoying valgrind, but I fixed it anyway.
Thanks for the report!
regards, tom lane
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Rethinking the implementation of ts_headline()
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox