From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Yugo NAGATA <nagata@sraoss.co.jp>, Fabien COELHO <coelho@cri.ensmp.fr>,
        pgsql-hackers@postgresql.org
Subject: Re: pgbench: using prepared BEGIN statement in a pipeline could cause an error
In-reply-to: <20230206101132.3oge5d5ovoirvxhb@alvherre.pgsql>
References: <20230206101132.3oge5d5ovoirvxhb@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Mon, 06 Feb 2023 11:11:32 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2663732.1675696981.1@sss.pgh.pa.us>
Date: Mon, 06 Feb 2023 10:23:01 -0500
Message-ID: <2663733.1675696981@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2663733.1675696981%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> I'm writing my own patch for this problem.  While playing around with
> it, I noticed this:

> struct Command {
>     /* size: 2168, cachelines: 34, members: 11 */
>     /* sum members: 2164, holes: 1, sum holes: 4 */
>     /* last cacheline: 56 bytes */
> };

I think the original intent was for argv[] to be at the end,
which fell victim to ye olde add-at-the-end antipattern.
Cache-friendliness-wise, putting it back to the end would
likely be enough.  But turning it into a variable-size array
would be better from a functionality standpoint.

			regards, tom lane