Content-Type: multipart/mixed; boundary="------------f3oo00Zci3uI4vRGq3jhN0J0"
Message-ID: <26678db0-519e-4c77-9b34-c5f94f97f6b9@gmail.com>
Date: Fri, 12 Dec 2025 22:46:45 -0600
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance
 chain
To: Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <e2b16375-7430-4053-bda3-5d2194ff1880@gmail.com>
 <CA+hUKGJS=xdaQ6iCTSgvBrf8Cm+a_ZMmDjZYhdQX_srHkhOuqA@mail.gmail.com>
 <7f6779d5-7a0e-44c5-a85f-b4ef265db766@gmail.com>
 <35f9236e-95d8-4f31-ac6b-ec54b7de4bac@gmail.com>
 <7412f694-7c57-41e5-ae37-71136070b0da@gmail.com>
 <CA+hUKGLX7t_PZjcUGm2-hL52RsKwof4F+-ENN5qc0AOBMPY1_g@mail.gmail.com>
 <ac7fe47b-0079-4711-9c58-73467b1d262a@gmail.com>
 <e3b982d0-c56e-441e-a5d5-61de571e313c@gmail.com>
 <CA+hUKGJh0a_6EP8NLh6jjQjzzg=Nm_h9HMC19-tBww7ZqQDWVg@mail.gmail.com>
 <CA+hUKGKbWCzBPYGKuoTG2_8uCvrKuoHkvpbjxLUYhPDiJHapNg@mail.gmail.com>
 <1086088.1765593851@sss.pgh.pa.us>
 <CA+hUKGJOVyea=EqZaMy9nt0Js10+E9y1FYL0=E_+UskZi-3wXQ@mail.gmail.com>
Content-Language: en-US
From: Bryan Green <dbryan.green@gmail.com>
In-Reply-To: 
 <CA+hUKGJOVyea=EqZaMy9nt0Js10+E9y1FYL0=E_+UskZi-3wXQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/26678db0-519e-4c77-9b34-c5f94f97f6b9%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------f3oo00Zci3uI4vRGq3jhN0J0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 12/12/2025 9:57 PM, Thomas Munro wrote:
> On Sat, Dec 13, 2025 at 3:44 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Thomas Munro <thomas.munro@gmail.com> writes:
>>> Hearing nothing, pushed.
>>
>> fairywren is unimpressed:
>>
>> ../pgsql/src/test/modules/test_cloexec/test_cloexec.c: In function 'run_parent_tests':
>> ../pgsql/src/test/modules/test_cloexec/test_cloexec.c:137:29: warning: unused variable 'space_pos' [-Wunused-variable]
>>   137 |                 char       *space_pos;
>>       |                             ^~~~~~~~~
> 
> The CI MinGW task also shows this warning, but it doesn't use -Werror.
> The separate CompileWarnings task does, being its purpose, and it
> includes a MinGW cross-build step, but that uses configure, and this
> test is built only by meson.  That wasn't a great idea... we knew we
> were only dealing with Windows but forgot about MinGW, so I'll go and
> write a patch to fix that aspect later today so we're covered for
> warnings.  I'll also think about whether it's worth checking for MinGW
> warnings in both assert and non-assert builds (as we do for regular
> Linux gcc/clang), and I'd also like to try to catch warnings from MSVC
> and had an idea for how to do that...  I might also try to think about
> meson-vs-configure cross checks...
> 
>> What is the point of that first snprintf(cmdline, ...), when its
>> result is guaranteed to be overwritten just below?
>>
>> I'm also dubious about using MAX_PATH here; see the commentary
>> about MAXPGPATH in pg_config_manual.h.  Also, what's the point of
>> using MAX_PATH when the result is going to be transferred into
>> cmdline (with a hardwired size of 1024)?
> 
> Fair points, I'll wait and see if Bryan is free to write a patch on
> Monday (US), and otherwise write one myself.
Thomas,

A sanity check would be appreciated after the somewhat embarrassing
sloppy code.

I removed the useless snprintf() call that was using GetCommandLine().
That was left in place when I moved to GetModuleFileName().  Also,
removed the unused 'space_pos' variable and the unneeded scope block.  I
decided to just use 1024 for the exe_path size since that is what
cmdline is set to use.  I also removed some self-evident comments that
were leftover from my practice of writing comments and then coding.


Apologies for the loss of time.

Thanks,

-- 
Bryan Green
EDB: https://www.enterprisedb.com
--------------f3oo00Zci3uI4vRGq3jhN0J0
Content-Type: text/plain; charset=UTF-8;
 name="v1-0001-Clean-up-sloppy-code-in-test_cloexec.patch"
Content-Disposition: attachment;
 filename="v1-0001-Clean-up-sloppy-code-in-test_cloexec.patch"
Content-Transfer-Encoding: base64

RnJvbSA3MjJkNjc1Y2FlNzdkMDQ2YjhlNTNhYmJjZjlmNTIxOGIzNzViMTgwIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBCcnlhbiBHcmVlbiA8ZGJyeWFuLmdyZWVuQGdtYWls
LmNvbT4KRGF0ZTogRnJpLCAxMiBEZWMgMjAyNSAyMjozMToxNSAtMDYwMApTdWJqZWN0OiBb
UEFUQ0ggdjFdIENsZWFuIHVwIHNsb3BweSBjb2RlIGluIHRlc3RfY2xvZXhlYy5jCgpUaGUg
Y29tbWFuZCBsaW5lIGNvbnN0cnVjdGlvbiBjb2RlIGluIHJ1bl9wYXJlbnRfdGVzdHMoKSBo
YWQgc2V2ZXJhbAppc3N1ZXM6CgoxLiBBIHVzZWxlc3Mgc25wcmludGYoKSBjYWxsIHRoYXQg
YnVpbHQgYSBjb21tYW5kIGxpbmUgdXNpbmcKICAgR2V0Q29tbWFuZExpbmUoKSwgd2hpY2gg
d2FzIGltbWVkaWF0ZWx5IG92ZXJ3cml0dGVuIGJ5IGEgc2Vjb25kCiAgIHNucHJpbnRmKCkg
dGhhdCBjb3JyZWN0bHkgdXNlZCBHZXRNb2R1bGVGaWxlTmFtZSgpIGluc3RlYWQuCgoyLiBB
biB1bnVzZWQgdmFyaWFibGUgJ3NwYWNlX3BvcycgdGhhdCB3YXMgZGVjbGFyZWQgYnV0IG5l
dmVyIHVzZWQuCgozLiBBbiB1bm5lY2Vzc2FyeSBzY29wZSBibG9jayBhcm91bmQgdGhlIEdl
dE1vZHVsZUZpbGVOYW1lKCkgY2FsbC4KCjQuIEluY29uc2lzdGVudCBidWZmZXIgc2l6aW5n
OiBleGVfcGF0aCB1c2VkIE1BWF9QQVRIIHdoaWxlIGNtZGxpbmUgdXNlZAogICAxMDI0Li4K
ClRoaXMgYXBwZWFycyB0byBiZSBjb2RlIHRoYXQgd2FzIHJlZmFjdG9yZWQgd2hlbiBpdCB3
YXMgcmVhbGl6ZWQKR2V0Q29tbWFuZExpbmUoKSB3b3VsZG4ndCB3b3JrIGNvcnJlY3RseSAo
aXQgcmV0dXJucyB0aGUgZnVsbCBjb21tYW5kCmxpbmUgd2l0aCBhcmd1bWVudHMsIG5vdCBq
dXN0IHRoZSBleGVjdXRhYmxlIHBhdGgpLCBidXQgdGhlIG9sZAphcHByb2FjaCB3YXMgbmV2
ZXIgZnVsbHkgcmVtb3ZlZC4KCkNsZWFuIHRoaXMgdXAgYnk6Ci0gUmVtb3ZpbmcgdGhlIHJl
ZHVuZGFudCBmaXJzdCBzbnByaW50ZigpIGNhbGwKLSBSZW1vdmluZyB0aGUgdW51c2VkIHNw
YWNlX3BvcyB2YXJpYWJsZQotIFJlbW92aW5nIHRoZSB1bm5lY2Vzc2FyeSBzY29wZSBibG9j
awotIFVzaW5nIGNvbnNpc3RlbnQgMTAyNC1ieXRlIGJ1ZmZlciBzaXplIGZvciBib3RoIGV4
ZV9wYXRoIGFuZCBjbWRsaW5lCi0gQWRkaW5nIGEgY2xlYXJlciBjb21tZW50IGV4cGxhaW5p
bmcgdGhlIHB1cnBvc2Ugb2YgdGhlIGNvZGUKLSBSZW1vdmVkIHNvbWUgc2ltcGxpc3RpYywg
dW5uZWVkZWQgY29tbWVudHMKLS0tCiBzcmMvdGVzdC9tb2R1bGVzL3Rlc3RfY2xvZXhlYy90
ZXN0X2Nsb2V4ZWMuYyB8IDM0ICsrKy0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdl
ZCwgNSBpbnNlcnRpb25zKCspLCAyOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMv
dGVzdC9tb2R1bGVzL3Rlc3RfY2xvZXhlYy90ZXN0X2Nsb2V4ZWMuYyBiL3NyYy90ZXN0L21v
ZHVsZXMvdGVzdF9jbG9leGVjL3Rlc3RfY2xvZXhlYy5jCmluZGV4IDlmNjQ1NDUxNjguLmEx
OGQ1M2E1ZDMgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9jbG9leGVjL3Rl
c3RfY2xvZXhlYy5jCisrKyBiL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9jbG9leGVjL3Rlc3Rf
Y2xvZXhlYy5jCkBAIC0zNCw3ICszNCw2IEBAIG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3Zb
XSkKIAljaGFyCQl0ZXN0ZmlsZTFbTUFYUEdQQVRIXTsKIAljaGFyCQl0ZXN0ZmlsZTJbTUFY
UEdQQVRIXTsKIAotCS8qIFdpbmRvd3Mtb25seSB0ZXN0ICovCiAjaWZuZGVmIFdJTjMyCiAJ
ZnByaW50ZihzdGRlcnIsICJUaGlzIHRlc3Qgb25seSBydW5zIG9uIFdpbmRvd3NcbiIpOwog
CXJldHVybiAwOwpAQCAtNTcsNyArNTYsNiBAQCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2
W10pCiAKIAkJcnVuX3BhcmVudF90ZXN0cyh0ZXN0ZmlsZTEsIHRlc3RmaWxlMik7CiAKLQkJ
LyogQ2xlYW4gdXAgdGVzdCBmaWxlcyAqLwogCQl1bmxpbmsodGVzdGZpbGUxKTsKIAkJdW5s
aW5rKHRlc3RmaWxlMik7CiAKQEAgLTc4LDYgKzc2LDcgQEAgcnVuX3BhcmVudF90ZXN0cyhj
b25zdCBjaGFyICp0ZXN0ZmlsZTEsIGNvbnN0IGNoYXIgKnRlc3RmaWxlMikKIAkJCQlmZDI7
CiAJSEFORExFCQloMSwKIAkJCQloMjsKKwljaGFyCQlleGVfcGF0aFsxMDI0XTsKIAljaGFy
CQljbWRsaW5lWzEwMjRdOwogCVNUQVJUVVBJTkZPIHNpOwogCVBST0NFU1NfSU5GT1JNQVRJ
T04gcGk7CkBAIC0xMDYsNyArMTA1LDYgQEAgcnVuX3BhcmVudF90ZXN0cyhjb25zdCBjaGFy
ICp0ZXN0ZmlsZTEsIGNvbnN0IGNoYXIgKnRlc3RmaWxlMikKIAkJZXhpdCgxKTsKIAl9CiAK
LQkvKiBHZXQgV2luZG93cyBIQU5ETEVzIGZyb20gZmlsZSBkZXNjcmlwdG9ycyAqLwogCWgx
ID0gKEhBTkRMRSkgX2dldF9vc2ZoYW5kbGUoZmQxKTsKIAloMiA9IChIQU5ETEUpIF9nZXRf
b3NmaGFuZGxlKGZkMik7CiAKQEAgLTEyMSwyNSArMTE5LDggQEAgcnVuX3BhcmVudF90ZXN0
cyhjb25zdCBjaGFyICp0ZXN0ZmlsZTEsIGNvbnN0IGNoYXIgKnRlc3RmaWxlMikKIAlwcmlu
dGYoIlBhcmVudDogZmQxPSVkIChPX0NMT0VYRUMpIC0+IEhBTkRMRT0lcFxuIiwgZmQxLCBo
MSk7CiAJcHJpbnRmKCJQYXJlbnQ6IGZkMj0lZCAobm8gT19DTE9FWEVDKSAtPiBIQU5ETEU9
JXBcbiIsIGZkMiwgaDIpOwogCi0JLyoKLQkgKiBTcGF3biBjaGlsZCBwcm9jZXNzIHdpdGgg
YkluaGVyaXRIYW5kbGVzPVRSVUUsIHBhc3NpbmcgaGFuZGxlIHZhbHVlcyBhcwotCSAqIGhl
eCBzdHJpbmdzCi0JICovCi0Jc25wcmludGYoY21kbGluZSwgc2l6ZW9mKGNtZGxpbmUpLCAi
XCIlc1wiICVwICVwIiwKLQkJCSBHZXRDb21tYW5kTGluZSgpLCBoMSwgaDIpOwotCi0JLyoK
LQkgKiBGaW5kIHRoZSBhY3R1YWwgZXhlY3V0YWJsZSBwYXRoIGJ5IHJlbW92aW5nIGFueSBh
cmd1bWVudHMgZnJvbQotCSAqIEdldENvbW1hbmRMaW5lKCkuCi0JICovCi0JewotCQljaGFy
CQlleGVfcGF0aFtNQVhfUEFUSF07Ci0JCWNoYXIJICAgKnNwYWNlX3BvczsKLQotCQlHZXRN
b2R1bGVGaWxlTmFtZShOVUxMLCBleGVfcGF0aCwgc2l6ZW9mKGV4ZV9wYXRoKSk7Ci0JCXNu
cHJpbnRmKGNtZGxpbmUsIHNpemVvZihjbWRsaW5lKSwgIlwiJXNcIiAlcCAlcCIsCi0JCQkJ
IGV4ZV9wYXRoLCBoMSwgaDIpOwotCX0KKwlHZXRNb2R1bGVGaWxlTmFtZShOVUxMLCBleGVf
cGF0aCwgc2l6ZW9mKGV4ZV9wYXRoKSk7CisJc25wcmludGYoY21kbGluZSwgc2l6ZW9mKGNt
ZGxpbmUpLCAiXCIlc1wiICVwICVwIiwgZXhlX3BhdGgsIGgxLCBoMik7CiAKIAltZW1zZXQo
JnNpLCAwLCBzaXplb2Yoc2kpKTsKIAlzaS5jYiA9IHNpemVvZihzaSk7CkBAIC0xNjcsNyAr
MTQ4LDYgQEAgcnVuX3BhcmVudF90ZXN0cyhjb25zdCBjaGFyICp0ZXN0ZmlsZTEsIGNvbnN0
IGNoYXIgKnRlc3RmaWxlMikKIAogCXByaW50ZigiUGFyZW50OiBXYWl0aW5nIGZvciBjaGls
ZCBwcm9jZXNzLi4uXG4iKTsKIAotCS8qIFdhaXQgZm9yIGNoaWxkIHRvIGNvbXBsZXRlICov
CiAJV2FpdEZvclNpbmdsZU9iamVjdChwaS5oUHJvY2VzcywgSU5GSU5JVEUpOwogCUdldEV4
aXRDb2RlUHJvY2VzcyhwaS5oUHJvY2VzcywgJmV4aXRfY29kZSk7CiAKQEAgLTE5MywxMiAr
MTczLDkgQEAgc3RhdGljIHZvaWQKIHJ1bl9jaGlsZF90ZXN0cyhjb25zdCBjaGFyICpoYW5k
bGUxX3N0ciwgY29uc3QgY2hhciAqaGFuZGxlMl9zdHIpCiB7CiAjaWZkZWYgV0lOMzIKLQlI
QU5ETEUJCWgxLAotCQkJCWgyOwotCWJvb2wJCWgxX3dvcmtlZCwKLQkJCQloMl93b3JrZWQ7
CisJSEFORExFCQloMSwgaDI7CisJYm9vbAkJaDFfd29ya2VkLCBoMl93b3JrZWQ7CiAKLQkv
KiBQYXJzZSBoYW5kbGUgdmFsdWVzIGZyb20gaGV4IHN0cmluZ3MgKi8KIAlpZiAoc3NjYW5m
KGhhbmRsZTFfc3RyLCAiJXAiLCAmaDEpICE9IDEgfHwKIAkJc3NjYW5mKGhhbmRsZTJfc3Ry
LCAiJXAiLCAmaDIpICE9IDEpCiAJewpAQCAtMjA5LDcgKzE4Niw2IEBAIHJ1bl9jaGlsZF90
ZXN0cyhjb25zdCBjaGFyICpoYW5kbGUxX3N0ciwgY29uc3QgY2hhciAqaGFuZGxlMl9zdHIp
CiAJcHJpbnRmKCJDaGlsZDogUmVjZWl2ZWQgSEFORExFMT0lcCAoc2hvdWxkIGZhaWwgLSBP
X0NMT0VYRUMpXG4iLCBoMSk7CiAJcHJpbnRmKCJDaGlsZDogUmVjZWl2ZWQgSEFORExFMj0l
cCAoc2hvdWxkIHdvcmsgLSBubyBPX0NMT0VYRUMpXG4iLCBoMik7CiAKLQkvKiBUcnkgdG8g
d3JpdGUgdG8gYm90aCBoYW5kbGVzICovCiAJaDFfd29ya2VkID0gdHJ5X3dyaXRlX3RvX2hh
bmRsZShoMSwgIkhBTkRMRTEiKTsKIAloMl93b3JrZWQgPSB0cnlfd3JpdGVfdG9faGFuZGxl
KGgyLCAiSEFORExFMiIpOwogCi0tIAoyLjUyLjAud2luZG93cy4xCgo=

--------------f3oo00Zci3uI4vRGq3jhN0J0--