Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1o9Cqv-0006mG-Pv
	for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Jul 2022 21:46:33 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1o9Cqu-0001Qe-OI
	for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Jul 2022 21:46:32 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1o9Cqu-0001O7-ET
	for pgsql-hackers@lists.postgresql.org; Wed, 06 Jul 2022 21:46:32 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1o9Cqs-0006Qb-Do
	for pgsql-hackers@postgresql.org; Wed, 06 Jul 2022 21:46:32 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 266LkRMS2670519;
	Wed, 6 Jul 2022 17:46:27 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
cc: David Rowley <dgrowleyml@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: automatically generating node support functions
In-reply-to: <2592455.1657140387@sss.pgh.pa.us>
References: <c1097590-a6a4-486a-64b1-e1f9cc0533ce@enterprisedb.com>
 <2f876203-7142-fa71-6d22-6ce00eb26869@enterprisedb.com>
 <c091e5cd-45f8-69ee-6a9b-de86912cc7e7@enterprisedb.com>
 <b85eec6e-a54b-6c72-97f8-2a6fbf4f9070@enterprisedb.com>
 <c683a356-4d22-4126-bf55-64ed54e06014@enterprisedb.com>
 <50fedc80-4104-bdc8-d777-04f030fc550f@dunslane.net>
 <7848b872-7a10-67b2-b55f-7c9c475ae863@enterprisedb.com>
 <40a2e977-98ba-0c01-af6c-9dfb39e864ba@enterprisedb.com>
 <812ea8eb-6827-ba32-6ec0-6714f7ffa5dd@enterprisedb.com>
 <2905876.1644858587@sss.pgh.pa.us>
 <bee9fdb0-cd10-5fdb-3027-c4b5a240bc74@enterprisedb.com>
 <CAApHDvppoxUxzRJbwF9oOF12ngdfNoPEMfDsu63+LREgGnheUw@mail.gmail.com>
 <968928d9-a526-a1b5-dc36-0355632a843e@enterprisedb.com>
 <c5906b07-220a-a3d4-8ff3-8ee593009424@enterprisedb.com>
 <1294462.1656875649@sss.pgh.pa.us>
 <57df9f30-d2cf-9126-28d4-ae40a2e733a9@enterprisedb.com>
 <1593978.1656953960@sss.pgh.pa.us>
 <b53b92e0-1153-a31a-8c52-157fa2e07771@enterprisedb.com>
 <2592455.1657140387@sss!
 .pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Wed, 06 Jul 2022 16:46:27 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2670517.1657143987.1@sss.pgh.pa.us>
Date: Wed, 06 Jul 2022 17:46:27 -0400
Message-ID: <2670518.1657143987@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/2670518.1657143987%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> I have gone through this and made some proposed changes (attached),
> and I think it is almost committable.

I see from the cfbot that it now needs to be taught about RelFileNumber...

			regards, tom lane