Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fnlXc-0003Tz-0O for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Aug 2018 14:03:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fnlXa-000562-7e for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Aug 2018 14:03:50 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fnlXZ-00055v-NC for pgsql-hackers@lists.postgresql.org; Thu, 09 Aug 2018 14:03:49 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fnlXX-0002Wt-7q for pgsql-hackers@postgresql.org; Thu, 09 Aug 2018 14:03:48 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w79E3h4r026727; Thu, 9 Aug 2018 10:03:43 -0400 From: Tom Lane To: Andres Freund cc: Peter Eisentraut , pgsql-hackers Subject: Re: remove ancient pre-dlopen dynloader code In-reply-to: <20180809123059.32g25qn7dgd33iyq@alap3.anarazel.de> References: <3e3c7552-978b-486a-1a4a-326ee31d0545@2ndquadrant.com> <20180809123059.32g25qn7dgd33iyq@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Thu, 09 Aug 2018 05:30:59 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <26725.1533823423.1@sss.pgh.pa.us> Date: Thu, 09 Aug 2018 10:03:43 -0400 Message-ID: <26726.1533823423@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Andres Freund writes: > On 2018-08-09 14:29:08 +0200, Peter Eisentraut wrote: >> The non-dlopen dynloader code for several operating systems is in some >> cases decades obsolete, and I have had some doubts that it would even >> compile anymore. Attached are patches for each operating system >> removing the obsolete code, with references to when it became obsolete. > Cool, I encountered those files a couple times when grepping for > things. +1 for the removal. LGTM, too. regards, tom lane