From: Nikolay Shaplov <n.shaplov@postgrespro.ru>
To: Alvaro Herrera <alvherre@2ndquadrant.com>, pgsql-hackers@postgresql.org
Subject: Re: [PROPOSAL] Move all am-related reloption code into
 src/backend/access/[am-name] and get rid of relopt_kind
Date: Wed, 25 May 2016 20:30:39 +0300
Message-ID: <2675173.UdFh6OGSxV@nataraj-amd64>
User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; )
In-Reply-To: <20160525172538.GA595980@alvherre.pgsql>
References: <20160525172538.GA595980@alvherre.pgsql>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

=D0=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 25 =D0=BC=D0=B0=D1=
=8F 2016 13:25:38 =D0=92=D1=8B =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB=
=D0=B8:
> Teodor Sigaev wrote:
> > >This all should me moved behind "access method" abstraction...
> >=20
> > +1 relopt_kind should be moved in am, at least. Or removed.
>=20
> Hm, but we have tablespace options too, so I'm not sure that using AM as
> abstraction level is correct.
We will use am for all indexes, and keep all the rest in relopotion.c for=20
non-indexes. May be divided options catalog into sections one section for e=
ach=20
kind.

And as I also would like to use this code for dynamic attoptions later, I=20
would like to remove relopt_kind at all. Because it spoils live in that cas=
e.

--=20
Nikolay Shaplov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company


--=20
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers