From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: initdb --no-locale=C doesn't work as specified when the environment is not C
In-reply-to: <20231127.120042.1919434306028321316.horikyota.ntt@gmail.com>
References: <20231122.162700.1995154567625541112.horikyota.ntt@gmail.com> <1696010.1700669041@sss.pgh.pa.us> <20231127.120042.1919434306028321316.horikyota.ntt@gmail.com>
Comments: In-reply-to Kyotaro Horiguchi <horikyota.ntt@gmail.com>
	message dated "Mon, 27 Nov 2023 12:00:42 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2678841.1704928563.1@sss.pgh.pa.us>
Date: Wed, 10 Jan 2024 18:16:03 -0500
Message-ID: <2678842.1704928563@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2678842.1704928563%40sss.pgh.pa.us>
Precedence: bulk

Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
> It seems somewhat intentional that only lc_messages references the
> environment at boot time. On the other hand, previously, in the
> absence of a specified locale, initdb would embed the environmental
> value in the configuration file, as it seems to be documented. Given
> that initdb is always used for cluster creation, it's unlikey that
> systems depend on this boot-time default for their operation.

Yeah, after further reflection there doesn't seem to be a lot of value
in leaving these entries commented-out, even in the cases where that's
technically correct.  Let's just go back to the old behavior of always
uncommenting them; that stood for years without complaints.  So I
committed your latest patch as-is.

> By the way, the lines around lc_* in the sample file seem to have
> somewhat inconsistent indentations. Wouldnt' it be preferable to fix
> this? (The attached doesn't that.)

They look all right if you assume the tab width is 8, which seems to
be what is used elsewhere in the file.  I think there's been some
prior discussion about whether to ban use of tabs at all in these
sample files, so as to reduce confusion about how wide the tabs are.
But I'm not touching that question today.

			regards, tom lane