Feedback-ID: i131946ab:Fastmail
Message-ID: <2679face-90c2-d031-01f5-dfadac710d6f@enterprisedb.com>
Date: Wed, 7 Sep 2022 07:10:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.13.0
Subject: Re: [RFC] building postgres with meson - v12
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>,
 John Naylor <john.naylor@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
 samay sharma <smilingsamay@gmail.com>, Nazir Bilal Yavuz <byavuz81@gmail.com>
References: <20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de>
 <20220827180447.zbmfk6sp2af4ntio@awork3.anarazel.de>
 <2180a97c-c026-1b6c-cec8-d6e499f97017@enterprisedb.com>
 <20220831181154.ebqkjahjzs5bttfa@awork3.anarazel.de>
 <CAFBsxsHOpxGeh0z8S5T3rOdHyvObZw89sqD+h_VNmfMJ6DOGbA@mail.gmail.com>
 <20220902163515.vonnesmbu6lsissq@awork3.anarazel.de>
 <20220902165723.yi2d7jf6mhc4k2dd@awork3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220902165723.yi2d7jf6mhc4k2dd@awork3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/2679face-90c2-d031-01f5-dfadac710d6f%40enterprisedb.com>
Precedence: bulk

On 02.09.22 18:57, Andres Freund wrote:
> Is it worth running ninja -t missingdeps as a test? At the time we run tests
> we'll obviously have built and thus collected "real" dependencies, so we would
> have the necessary information to determine whether dependencies are missing.
> I think it'd be fine to do so only for ninja >= 1.11, rather than falling back
> to the llvm python implementation, which is much slower (0.068s vs
> 3.760s). And also because it's not as obvious how to include the python script.
> 
> Alternatively, we could just document that ninja -t missingdeps is worth
> running. Perhaps at the top of the toplevel build.meson file?

In the GNU/make world there is a distinction between "check" and 
"maintainer-check" for this kind of thing.

I think here if we put these kinds of things into a different, what's 
the term, "suite", then that would be a clear way to collect them and be 
able to run them all easily.