From: Tom Lane <tgl@sss.pgh.pa.us>
To: Greg Nancarrow <gregn4422@gmail.com>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Peter Smith <smithpb2250@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: PublicationActions - use bit flags.
In-reply-to: 
 <CAJcOf-d0T+9jy3ois4eytkX_NPpfWMiSA5a=23_5TXSiU26BEg@mail.gmail.com>
References: <3b7f2bdd-77ed-00d7-437c-dd9c37e6a2fa@enterprisedb.com>
 <202112201714.ql732mnfdrtc@alvherre.pgsql>
 <CAJcOf-d0T+9jy3ois4eytkX_NPpfWMiSA5a=23_5TXSiU26BEg@mail.gmail.com>
Comments: In-reply-to Greg Nancarrow <gregn4422@gmail.com>
	message dated "Tue, 21 Dec 2021 11:19:16 +1100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2683409.1640048186.1@sss.pgh.pa.us>
Date: Mon, 20 Dec 2021 19:56:26 -0500
Message-ID: <2683410.1640048186@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2683410.1640048186%40sss.pgh.pa.us>
Precedence: bulk

Greg Nancarrow <gregn4422@gmail.com> writes:
> I've attached a patch which addresses that and replaces a couple of
> memcpy()s with struct assignment, as suggested.

Removing this is not good:

 	if (relation->rd_pubactions)
-	{
 		pfree(relation->rd_pubactions);
-		relation->rd_pubactions = NULL;
-	}
 
If the subsequent palloc fails, you've created a problem where
there was none before.

I do wonder why we have to palloc a constant-size substructure in
the first place, especially one that is likely smaller than the
pointer that points to it.  Maybe the struct definition should be
moved so that we can just declare it in-line in the relcache entry?

			regards, tom lane