From: Tom Lane <tgl@sss.pgh.pa.us>
To: emre@hasegeli.com
cc: =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
        Andrew Dunstan <andrew@dunslane.net>,
        Matthias Kurz <m.kurz@irregular.at>,
        Jim Nasby <Jim.Nasby@bluetreble.com>,
        "David G. Johnston" <david.g.johnston@gmail.com>
Subject: Re: [PATCH] Alter or rename enum value
In-reply-to: 
 <CAE2gYzy9fWFmMgnA0DstcGdtuFv40d3JXgtikE-ywtZ2qow=ng@mail.gmail.com>
References: 
 <CAO=2mx6uvgPaPDf-rHqG8=1MZnGyVDMQeh8zS4euRyyg4D35OQ@mail.gmail.com>
 <56E049CC.8010201@dunslane.net> <25605.1457539654@sss.pgh.pa.us>
 <56E05635.70908@dunslane.net> <28167.1457543612@sss.pgh.pa.us>
 <CAO=2mx4rQHRvifT2yUQ1rz90A=9CVz4_Z0Sx1wTgwgQRzAimpQ@mail.gmail.com>
 <CAO=2mx6rK_h4BC7y+3Nu-8fuZJXdFjd9FE_MZnzkH+vnMp0C-Q@mail.gmail.com>
 <d8ja8ln7nl0.fsf@dalvik.ping.uio.no> <d8jk2kn4yn0.fsf_-_@dalvik.ping.uio.no>
 <d8jeg5m4as8.fsf@dalvik.ping.uio.no>
 <CAE2gYzxo4bB_uQDafQYoGx=WmUrO-NFUbKBYfu4j_=LfaaUzFg@mail.gmail.com>
 <d8jy43m2wow.fsf@dalvik.ping.uio.no>
 <CAE2gYzy9fWFmMgnA0DstcGdtuFv40d3JXgtikE-ywtZ2qow=ng@mail.gmail.com>
Comments: In-reply-to Emre Hasegeli <emre@hasegeli.com>
	message dated "Wed, 24 Aug 2016 16:47:19 +0200"
Date: Sat, 03 Sep 2016 16:48:04 -0400
Message-ID: <26875.1472935684@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Emre Hasegeli <emre@hasegeli.com> writes:
> Other than these, it looks good to me.  I am marking it as Ready for Committer.

I started looking at this patch.  I'm kind of unhappy with having *both*
IF EXISTS and IF NOT EXISTS options on the statement, especially since
the locations of those phrases in the syntax seem to have been chosen
with a dartboard.  This feels way more confusing than it is useful.
Is there really a strong use-case for either option?  I note that
ALTER TABLE RENAME COLUMN, which is probably used a thousand times
more often than this will be, has so far not grown either kind of option,
which sure makes me think that this proposal is getting ahead of itself.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers