Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fDerl-0006Z3-My
	for pgsql-hackers@arkaria.postgresql.org; Tue, 01 May 2018 23:39:25 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fDerk-0002Ez-K1
	for pgsql-hackers@arkaria.postgresql.org; Tue, 01 May 2018 23:39:24 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fDerk-0002Ep-Cu
	for pgsql-hackers@lists.postgresql.org; Tue, 01 May 2018 23:39:24 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fDerg-0003RU-7G
	for pgsql-hackers@postgresql.org; Tue, 01 May 2018 23:39:23 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w41NdDhb026881;
	Tue, 1 May 2018 19:39:13 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
cc: Michael Paquier <michael@paquier.xyz>,
        Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: A few warnings on Windows
In-reply-to: 
 <CAEepm=3Q9y5mUcheKZ2jC9yFn8jb9Z-5vF03WE0mPD-JskSZVQ@mail.gmail.com>
References: 
 <CAEepm=3=TDYEXUEcHpEx+Twc31wo7PA0oBAiNt6sWmq93MW02A@mail.gmail.com>
 <20180501083026.GB25848@paquier.xyz> <15083.1525207729@sss.pgh.pa.us>
 <CAEepm=2AQxJENLfhZzU-=AcxmHXbDXV=kEdzPh7hjQrmmuHxWQ@mail.gmail.com>
 <CAEepm=3Q9y5mUcheKZ2jC9yFn8jb9Z-5vF03WE0mPD-JskSZVQ@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@enterprisedb.com>
	message dated "Wed, 02 May 2018 10:29:17 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <26879.1525217953.1@sss.pgh.pa.us>
Date: Tue, 01 May 2018 19:39:13 -0400
Message-ID: <26880.1525217953@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Thomas Munro <thomas.munro@enterprisedb.com> writes:
> Here's a patch that builds warning-free for me.  Result:
> https://ci.appveyor.com/project/macdice/postgres/build/1.0.139

LGTM, pushed.

> Unfortunately my scripting for that doesn't actually build the plperl
> stuff yet (need to cannibalise more buildfarm scripts...) so I can't
> confirm that it'll fix the true/false redefinition warnings visible on
> whelk (VC 2013) and dory (2015) but not hamerkop (2005), thrips
> (2010), bowerbird (2012).  It seems likely.

We'll soon find out.

			regards, tom lane