Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1r3Jxa-0037HU-Ic
	for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Nov 2023 17:45:54 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1r3JxY-0014ht-FW
	for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Nov 2023 17:45:52 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1r3JxY-0014hl-5s
	for pgsql-hackers@lists.postgresql.org; Wed, 15 Nov 2023 17:45:52 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1r3JxV-006b7S-ME
	for pgsql-hackers@postgresql.org; Wed, 15 Nov 2023 17:45:51 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 3AFHjk992689178;
	Wed, 15 Nov 2023 12:45:46 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Tristan Partin" <tristan@neon.tech>
cc: "pgsql-hackers" <pgsql-hackers@postgresql.org>
Subject: Re: On non-Windows, hard depend on uselocale(3)
In-reply-to: <CWZBBRR6YA8D.8EHMDRGLCKCD@neon.tech>
References: <CWZBBRR6YA8D.8EHMDRGLCKCD@neon.tech>
Comments: In-reply-to "Tristan Partin" <tristan@neon.tech>
	message dated "Wed, 15 Nov 2023 04:27:49 -0600"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2689176.1700070346.1@sss.pgh.pa.us>
Date: Wed, 15 Nov 2023 12:45:46 -0500
Message-ID: <2689177.1700070346@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/2689177.1700070346%40sss.pgh.pa.us>
Precedence: bulk

"Tristan Partin" <tristan@neon.tech> writes:
> I would like to propose removing HAVE_USELOCALE, and just have WIN32, 
> which means that Postgres would require uselocale(3) on anything that 
> isn't WIN32.

You would need to do some research and try to prove that that won't
be a problem on any modern platform.  Presumably it once was a problem,
or we'd not have bothered with a configure check.

(Some git archaeology might yield useful info about when and why
we added the check.)

			regards, tom lane