Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jB0fk-0007dl-Hg
	for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Mar 2020 18:29:08 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jB0fj-0001uM-1Q
	for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Mar 2020 18:29:07 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jB0fi-0001uF-Oz
	for pgsql-hackers@lists.postgresql.org; Sun, 08 Mar 2020 18:29:06 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jB0fd-0002hl-7g
	for pgsql-hackers@postgresql.org; Sun, 08 Mar 2020 18:29:06 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 028ISvJG026907;
	Sun, 8 Mar 2020 14:28:57 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove utils/acl.h from catalog/objectaddress.h
In-reply-to: <7601e258-26b2-8481-36d0-dc9dca6f28f1@2ndquadrant.com>
References: <7601e258-26b2-8481-36d0-dc9dca6f28f1@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Sat, 07 Mar 2020 08:25:22 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <26905.1583692137.1@sss.pgh.pa.us>
Date: Sun, 08 Mar 2020 14:28:57 -0400
Message-ID: <26906.1583692137@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> I noticed that catalog/objectaddress.h includes utils/acl.h for no 
> apparent reason.  It turns out this used to be needed but not anymore. 
> So removed it and cleaned up the fallout.  Patch attached.

Seems reasonable.  One thing I noticed is that if you are including
nodes/parsenodes.h explicitly in objectaddress.h, there seems little
point in the #include "nodes/pg_list.h" right beside it.

Sometime we really ought to make an effort to make our header inclusions
less of a mass of spaghetti.  But this patch needn't take on that load.

			regards, tom lane