Message-ID: <26eaf58751e03d52cb200064ca8f84f940b9c0bf.camel@postgresql.org>
Subject: Re: Thread-unsafe coding in ecpg
From: Michael Meskes <meskes@postgresql.org>
To: Tom Lane <tgl@sss.pgh.pa.us>, "Tsunakawa, Takayuki"
	 <tsunakawa.takay@jp.fujitsu.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: Mon, 21 Jan 2019 18:51:56 +0100
In-Reply-To: <13850.1548090570@sss.pgh.pa.us>
References: <31420.1547783697@sss.pgh.pa.us>
	 <0be2e83c4dec0d2f1f8eb55b1e95ad98b12ede24.camel@postgresql.org>
	 <23046.1547943059@sss.pgh.pa.us>
	 <907962be808367ff475893ce07a8442700e3e65a.camel@postgresql.org>
	 <24002.1547944649@sss.pgh.pa.us>
	 <d441f5913b147e5b3e0eed4647f9839d926d90fc.camel@postgresql.org>
	 <29905.1548005448@sss.pgh.pa.us> <29984.1548014676@sss.pgh.pa.us>
	 <0A3221C70F24FB45833433255569204D1FB6C47E@G01JPEXMBYT05>
	 <21439.1548037255@sss.pgh.pa.us>
	 <0A3221C70F24FB45833433255569204D1FB6C4FA@G01JPEXMBYT05>
	 <32316.1548040561@sss.pgh.pa.us>
	 <0A3221C70F24FB45833433255569204D1FB6C6C0@G01JPEXMBYT05>
	 <13850.1548090570@sss.pgh.pa.us>
Organization: PostgreSQL
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.4-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

> Thanks for reviewing!  I've pushed this now (to HEAD only for the
> moment),
> we'll see what the buildfarm thinks.
> 
> BTW, I found another spot in descriptor.c where ecpglib is using
> setlocale() for the same purpose.  Perhaps that one's not reachable
> in threaded apps, but I didn't see any obvious reason to think so,
> so I changed it too.

Thanks Tom.

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL