Subject: Re: backend type in log_line_prefix?
To: Kuntal Ghosh <kuntalghosh.2007@gmail.com>
References: <c65e5196-4f04-4ead-9353-6088c19615a3@2ndquadrant.com>
 <6453e044-041a-bf64-c76a-e1b7e3d5b0e7@2ndquadrant.com>
 <b749274f-049e-c971-b777-94e2202c0471@2ndquadrant.com>
 <CAGz5QCL6NnWgTNJzruWso=dD4vxctP+ZYtnBcbe8eYxud7Y8Fg@mail.gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <26fb28aa-b614-e3ca-344b-d98058496d52@2ndquadrant.com>
Date: Tue, 10 Mar 2020 16:41:23 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: 
 <CAGz5QCL6NnWgTNJzruWso=dD4vxctP+ZYtnBcbe8eYxud7Y8Fg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-03-09 16:20, Kuntal Ghosh wrote:
> In v3-0001-Refactor-ps_status.c-API.patch,
> 
> - *
> - * For a walsender, the ps display is set in the following form:
> - *
> - * postgres: walsender <user> <host> <activity>
> This part is still valid, right?

Sure but I figured this comment was in the context of the explanation of 
how the old API was being abused, so it's no longer necessary.

> + init_ps_display(ps_data.data);
> + pfree(ps_data.data);
> +
> + set_ps_display("initializing");
> As per the existing behaviour, if update_process_title is true, we
> display "authentication" as the initial string. On the other hand,
> this patch, irrespective of the GUC variable, always displays
> "initializing" as the initial string and In PerformAuthentication, it
> sets the display as "authentication" Is this intended? Should we check
> the GUC here as well?

set_ps_display() checks update_process_title itself and does nothing if 
it's off, so this should work okay.

> In v3-0002-Unify-several-ways-to-tracking-backend-type.patch,
> + * If fixed_part is NULL, a default will be obtained from BackendType.
> s/BackendType/MyBackendType?

yup

> In v3-0003-Add-backend-type-to-csvlog-and-optionally-log_lin.patch,
> +             <entry>Backend process type</entry>
> In other places you've written "backend type".

ok changed

> 
> In v3-0004-Remove-am_syslogger-global-variable.patch,
> + * This is exported so that elog.c can call it when BackendType is B_LOGGER.
> s/BackendType/MyBackendType?

ok

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services