From: Nikolay Shaplov <dhyan@nataraj.su>
To: Alvaro Herrera <alvherre@2ndquadrant.com>, pgsql-hackers@postgresql.org
Subject: BRIN autosummarize tests
Date: Wed, 19 Apr 2017 19:53:57 +0300
Message-ID: <2700647.XEouBYNZic@x200m>
User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; )
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


Hi!

Alvaro, you've recently commited patch with BRIN autosummarize

Tell me, this feature can't be really tested via regression tests?

Because now I am rebasing my reloptions patch (again!), and as it was partly 
rebased, I run make check. 
At that point I did not moved implementation of this option completely, and 
thus autosummarize were forever set to false.

And in this obviously broken situation all tests were successful when I run 
them. May be there can be a way to make sure it is really works, and one 
should add it to the tests?


-- 
Nikolay Shaplov, independent Perl & C/C++ developer. Available for hire.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers