Content-Type: multipart/alternative;
 boundary="------------3kcCyw0Mhj89gvdk5iVBjKxs"
Message-ID: <2701ad84-05c9-6381-1666-b874c3000d54@dunslane.net>
Date: Mon, 13 Feb 2023 07:57:25 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: run pgindent on a regular basis / scripted manner
Content-Language: en-US
To: Justin Pryzby <pryzby@telsasoft.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jelte Fennema <postgres@jeltef.nl>, shiy.fnst@fujitsu.com,
 Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>,
 Noah Misch <noah@leadboat.com>, Peter Geoghegan <pg@bowt.ie>,
 Bruce Momjian <bruce@momjian.us>, Magnus Hagander <magnus@hagander.net>,
 Alvaro Herrera <alvherre@2ndquadrant.com>, Stephen Frost
 <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
 pgsql-hackers@postgresql.org
References: <CAGECzQRJrcoxozHh=BRTdLrirFui-3nvdRZru7GGa4F9HJV2Rw@mail.gmail.com>
 <b8f18576-afc0-d961-b33b-c0fa2e63edeb@dunslane.net>
 <0f074818-b01a-799f-3c74-5fb5deab1d23@dunslane.net>
 <CAGECzQSUYmfTwEWcVfwb4d=vf=M7RYJjq6ie0YPTUhP+YFcEww@mail.gmail.com>
 <1d66447e-a77b-ca0d-90a0-782800e85383@dunslane.net>
 <TYAPR01MB6315B86619944D4A6B56842DFDDE9@TYAPR01MB6315.jpnprd01.prod.outlook.com>
 <CAGECzQT44xN-zcTQ0+OxLpWa9nONxmEaYxQpaWM+My+A4o72PA@mail.gmail.com>
 <390e7b04-11f3-f715-7a7d-d1a9077fbea8@dunslane.net>
 <00885533-!ff96-2a95-7911-329c873b3029@dunslane.net>
 <842819.1676219054@sss.pgh.pa.us> <20230212205936.GV1653@telsasoft.com>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <20230212205936.GV1653@telsasoft.com>
Archived-At: <https://www.postgresql.org/message-id/2701ad84-05c9-6381-1666-b874c3000d54%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------3kcCyw0Mhj89gvdk5iVBjKxs
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2023-02-12 Su 15:59, Justin Pryzby wrote:
> It seems like if pgindent knows about git, it ought to process only
> tracked files.  Then, it wouldn't need to manually exclude generated
> files, and it wouldn't process vpath builds and who-knows-what else it
> finds in CWD.


for vpath builds use an exclude file that excludes the vpath you use.

I don't really want restrict this to tracked files because it would mean 
you can't pgindent files before you `git add` them. And we would still 
need to do manual exclusion for some files that are tracked, e.g. the 
snowball files.


>
> At least --commit doesn't seem to work when run outside of the root
> source dir.
>

Yeah, I'll fix that, thanks for mentioning.


cheers


andrew


--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------3kcCyw0Mhj89gvdk5iVBjKxs
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2023-02-12 Su 15:59, Justin Pryzby
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:20230212205936.GV1653@telsasoft.com">
      <pre class="moz-quote-pre" wrap="">It seems like if pgindent knows about git, it ought to process only
tracked files.  Then, it wouldn't need to manually exclude generated
files, and it wouldn't process vpath builds and who-knows-what else it
finds in CWD.</pre>
    </blockquote>
    <p><br>
    </p>
    <p>for vpath builds use an exclude file that excludes the vpath you
      use.</p>
    <p>I don't really want restrict this to tracked files because it
      would mean you can't pgindent files before you `git add` them. And
      we would still need to do manual exclusion for some files that are
      tracked, e.g. the snowball files.<br>
    </p>
    <p><br>
    </p>
    <blockquote type="cite"
      cite="mid:20230212205936.GV1653@telsasoft.com">
      <pre class="moz-quote-pre" wrap="">

At least --commit doesn't seem to work when run outside of the root
source dir.

</pre>
    </blockquote>
    <p><br>
    </p>
    <p>Yeah, I'll fix that, thanks for mentioning.</p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <p><br>
    </p>
    <pre class="moz-signature" signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------3kcCyw0Mhj89gvdk5iVBjKxs--