From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Melih Mutlu <m.melihmutlu@gmail.com>,
        Thomas Munro <thomas.munro@gmail.com>,
        "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: wake up logical workers after ALTER SUBSCRIPTION
In-reply-to: <20221214171023.GA689106@nathanxps13>
References: <20221202192101.GB2277157@nathanxps13>
 <CAGPVpCTUuKyxB5f3exgDMBRTivbN5uHVkD=YfXmgznrdnwVOQw@mail.gmail.com>
 <20221206192551.GA3078082@nathanxps13> <20221206212954.GA3403597@nathanxps13>
 <CAGPVpCTkdaOyBLXB435VXq0RA1cHLFQut7BPm6t8D4dsdiEXZQ@mail.gmail.com>
 <20221207181145.GA3698731@nathanxps13> <2550453.1670974328@sss.pgh.pa.us>
 <20221214000145.GA638663@nathanxps13> <2561155.1670977214@sss.pgh.pa.us>
 <20221214004105.GA669835@nathanxps13> <20221214171023.GA689106@nathanxps13>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Wed, 14 Dec 2022 09:10:23 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2707694.1671039752.1@sss.pgh.pa.us>
Date: Wed, 14 Dec 2022 12:42:32 -0500
Message-ID: <2707695.1671039752@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2707695.1671039752%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> My first thought is that the latter two uses should be moved to a new
> parameter, and the apply launcher should store the last start time for each
> apply worker like the apply workers do for the table-sync workers.  In any
> case, it probably makes sense to lower this parameter's value for testing
> so that tests that restart these workers frequently aren't waiting for so
> long.

> I can put a patch together if this seems like a reasonable direction to go.

No, I'm still of the opinion that waiting for the launcher to timeout
before doing something is fundamentally wrong design.  We should signal
it when we want it to do something.  That's not different from what
you're fixing about the workers; why don't you see that it's appropriate
for the launcher too?

			regards, tom lane