Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rl0GG-00Gzdu-51
	for pgsql-hackers@arkaria.postgresql.org; Fri, 15 Mar 2024 05:37:44 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rl0GE-006Aew-AD
	for pgsql-hackers@arkaria.postgresql.org; Fri, 15 Mar 2024 05:37:42 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <david@pgmasters.net>)
	id 1rl0GE-006Aem-14
	for pgsql-hackers@lists.postgresql.org; Fri, 15 Mar 2024 05:37:42 +0000
Received: from mail.thelabyrinth.net ([45.56.70.56])
	by magus.postgresql.org with esmtps  (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <david@pgmasters.net>)
	id 1rl0GB-004b7k-Tp
	for pgsql-hackers@lists.postgresql.org; Fri, 15 Mar 2024 05:37:41 +0000
Received: from [192.168.68.63] (125-236-186-114.jetstream.xtra.co.nz
 [125.236.186.114])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: dsteele)
	by mail.thelabyrinth.net (Postfix) with ESMTPSA id E725054667;
	Fri, 15 Mar 2024 05:37:37 +0000 (UTC)
Message-ID: <2712cbf6-86f9-4194-8a2b-be4b6023ea87@pgmasters.net>
Date: Fri, 15 Mar 2024 18:37:35 +1300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Add basic tests for the low-level backup method.
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
References: <03e4cf19-fb76-4891-accc-edd429a25b21@pgmasters.net>
 <431ecc5d-8c07-4ee1-b05e-3ca536e606bb@pgmasters.net>
 <ZeAAPW8h1uxvt4Bj@paquier.xyz>
 <4980aba2-9cd4-4bd6-b2e1-e873639ab7ee@pgmasters.net>
 <ZfFEfImMw1gtA9zJ@paquier.xyz>
 <f20fcc82-dadb-478d-beb4-1e2ffb0ace76@pgmasters.net>
 <ZfKgnG09TRKAnDb6@paquier.xyz>
 <1c85f906-85d4-4479-9791-062989fec352@pgmasters.net>
 <ZfOKh0U51IhnIdkp@paquier.xyz>
 <89f477dc-c3e5-412e-9765-61c214aa69ab@pgmasters.net>
 <ZfPdhMJnbDNpEb_R@paquier.xyz>
From: David Steele <david@pgmasters.net>
In-Reply-To: <ZfPdhMJnbDNpEb_R@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/2712cbf6-86f9-4194-8a2b-be4b6023ea87%40pgmasters.net>
Precedence: bulk

On 3/15/24 18:32, Michael Paquier wrote:
> On Fri, Mar 15, 2024 at 06:23:15PM +1300, David Steele wrote:
>> Well, this is what we recommend in the docs, i.e. using bin mode to save
>> backup_label, so it seems OK to me.
> 
> Indeed, I didn't notice that this is actually documented, so what I
> did took the right angle.  French flair, perhaps..

This seems like a reasonable explanation to me.

-David