Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKixr-0003A7-Nx for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Jan 2023 16:49:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pKixq-0004qj-Hu for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Jan 2023 16:49:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKixq-0004oA-7g for pgsql-hackers@lists.postgresql.org; Wed, 25 Jan 2023 16:49:34 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKixo-0005Jd-4P for pgsql-hackers@postgresql.org; Wed, 25 Jan 2023 16:49:33 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30PGnRYU2715455; Wed, 25 Jan 2023 11:49:27 -0500 From: Tom Lane To: Kyotaro Horiguchi cc: nathandbossart@gmail.com, houzj.fnst@fujitsu.com, amit.kapila16@gmail.com, m.melihmutlu@gmail.com, thomas.munro@gmail.com, kuroda.hayato@fujitsu.com, pgsql-hackers@postgresql.org Subject: Re: wake up logical workers after ALTER SUBSCRIPTION In-reply-to: <20230125.161200.735003108705492225.horikyota.ntt@gmail.com> References: <20230124171329.GA677220@nathanxps13> <2268133.1674584035@sss.pgh.pa.us> <20230124184217.GA724858@nathanxps13> <20230125.161200.735003108705492225.horikyota.ntt@gmail.com> Comments: In-reply-to Kyotaro Horiguchi message dated "Wed, 25 Jan 2023 16:12:00 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2715453.1674665367.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 25 Jan 2023 11:49:27 -0500 Message-ID: <2715454.1674665367@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Kyotaro Horiguchi writes: > At Tue, 24 Jan 2023 10:42:17 -0800, Nathan Bossart wrote in = >> Here is a first attempt at a patch. I scanned through all the existing >> uses of InvalidDsaPointer and DSM_HANDLE_INVALID and didn't notice anyt= hing >> else that needed adjusting. > There seems to be two cases for DSA_HANDLE_INVALID in dsa_get_handle > and dsa_attach_in_place, one of which is Assert(), though. Right. I fixed some other infelicities and pushed it. regards, tom lane