From: Tom Lane <tgl@sss.pgh.pa.us>
To: "jean.pierre.pelletier0" <jean.pierre.pelletier0@gmail.com>
cc: pgsql-hackers@postgresql.org, Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Re: psql \dC incorrectly shows casts "with inout" as "binary
 coercible" on 9.5.14 and 11beta3
In-reply-to: <5b887023.1c69fb81.ff96e.6a1d@mx.google.com>
References: <5b887023.1c69fb81.ff96e.6a1d@mx.google.com>
Comments: In-reply-to "jean.pierre.pelletier0"
 <jean.pierre.pelletier0@gmail.com>
	message dated "Thu, 30 Aug 2018 18:30:57 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <27177.1535725990.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 31 Aug 2018 10:33:10 -0400
Message-ID: <27178.1535725990@sss.pgh.pa.us>
Precedence: bulk

"jean.pierre.pelletier0" <jean.pierre.pelletier0@gmail.com> writes:
> To reproduce, compare the output of \dC on two built-in casts(json to js=
onb) and (xml to text) where only the the first is really "with inout".

Hm, yeah, it just does

                      "       CASE WHEN castfunc =3D 0 THEN '(binary coerc=
ible)'\n"
                      "            ELSE p.proname\n"
                      "       END as \"%s\",\n"

without regard for the castmethod column (which it can't necessarily
assume is there, anyway).  It's hard to be sure after all these
years whether this was intentional or just an oversight, unless maybe
Heikki remembers ... but I tend to agree that "(with inout)" would be
more apropos than "(binary coercible)".

Not sure if this rises to the level of a back-patchable bug.
People might be surprised if we change that output in minor releases.
But we could still squeeze it into v11, I think.

			regards, tom lane