Message-ID: <271ebb35-8d8f-41c3-9d95-5c1e5b416216@gmail.com>
Date: Tue, 21 Apr 2026 16:23:33 -0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: MERGE PARTITIONS and DEPENDS ON EXTENSION.
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Dmitry Koval <d.koval@postgrespro.ru>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: 
 <CALdSSPjXtzGM7Uk4fWRwRMXcCczge5uNirPQcYCHKPAWPkp9iQ@mail.gmail.com>
 <31d04a1b-c0cb-4e6f-a344-0db048a3b673@gmail.com>
 <DHMZH5ILXV80.36CLMWXU18J3@gmail.com>
 <414c3430-77a9-438e-9dc0-c66033f6be63@postgrespro.ru>
 <DHURZGPYE4B4.2XG5GT4TQ72U4@gmail.com>
 <CAPpHfdvQSmRAHu1BRTVcvgons_Smt0QW+mLP4np=QxG==WyFAg@mail.gmail.com>
 <DHYV404JC894.P813UU2Y36L1@gmail.com>
 <CAPpHfds2NsGvpi4fK-xBDk9S=ZY8FEsG-a3z7m_cRSJhn5GKvQ@mail.gmail.com>
Content-Language: en-US
From: Matheus Alcantara <matheusssilv97@gmail.com>
In-Reply-To: 
 <CAPpHfds2NsGvpi4fK-xBDk9S=ZY8FEsG-a3z7m_cRSJhn5GKvQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/271ebb35-8d8f-41c3-9d95-5c1e5b416216%40gmail.com>
Precedence: bulk

On 21/04/26 12:57, Alexander Korotkov wrote:
> I've spotted the following things in this patch.
> 1) The equality of dependencies is not fully checked.  We only check
> that for each new dependency, we have the same for previous partition,
> but not vise versa.
> 2) The complexity of dependency checking is O(n^2).
> 3) Usage of citext and other extensions in src/test/regress where they
> might be not available.
> 

Oops, I forgot to replace the citext extension on split partition tests.

> I've revised the patch.
> 1) collectPartitionIndexExtDeps() is rewritten().  Now it works in
> three phases: collect, sort, compare.  The comparison phase requires
> strict equivalence of dependencies and doesn't depend on the order.
> The complexity is now O(n * log(n)), which I think is acceptable.
> 2) PartitionIndexExtDepEntry struct now have indexOid.  So, on
> conflict error contains both partition index names.
> 3) Tests moved to
> src/test/modules/test_extensions/sql/test_extdepend.sql where
> test_ext3/test_ext5 extensions are available.
> 4) More tests for different scenarios.
> 
> Could you, please, review this changes?
> 

I think that you miss to include the patch?

--
Matheus Alcantara
EDB: https://www.enterprisedb.com