From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Robert Haas <robertmhaas@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Andrew Dunstan <andrew@dunslane.net>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Thomas Munro <thomas.munro@gmail.com>,
        Melanie Plageman <melanieplageman@gmail.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Daniel Gustafsson <daniel@yesql.se>
Subject: Re: Adding CI to our tree
In-reply-to: <20220213191456.gdrhfu7vhvaifypd@alap3.anarazel.de>
References: <20220117201619.3ltudwhgk2krmoki@alap3.anarazel.de>
 <20220118210847.GC23027@telsasoft.com> <20220203035827.GG23027@telsasoft.com>
 <20220203195718.smqo5xg4ygp5qktq@alap3.anarazel.de>
 <20220204050403.GL23027@telsasoft.com>
 <20220213012008.4wpqzyszxu3z22d2@alap3.anarazel.de>
 <20220213051937.GO31460@telsasoft.com>
 <20220213083006.f2wulffsxr5zfwc4@alap3.anarazel.de>
 <CA+TgmoYbN=mkUcm_BY2VBqpJTqz4e81C3NXWjqayg6i_xnrRWg@mail.gmail.com>
 <2597660.1644772397@sss.pgh.pa.us>
 <20220213191456.gdrhfu7vhvaifypd@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sun, 13 Feb 2022 11:14:56 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2723723.1644782960.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 13 Feb 2022 15:09:20 -0500
Message-ID: <2723724.1644782960@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2723724.1644782960%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2022-02-13 12:13:17 -0500, Tom Lane wrote:
>> Right.  Can we set things up so that it's not too painful to inject
>> custom build options into a CI build?

> What kind of injection are you thinking about?

That's exactly what needs to be decided.

> A patch author can obviously
> just add options in .cirrus.yml. That's something possible now, that was=
 not
> possible with cfbot applying its own .cirrus.yml

Fine, but are committers supposed to keep track of the fact that they
shouldn't commit that part of a patch?  I'd prefer something a bit more
out-of-band.  I don't know this technology well enough to propose a way.

> I'd like to have things like -fanitize=3Daligned and
> -DWRITE_READ_PARSE_PLAN_TREES on by default for CI, primarily for cfbot'=
s
> benefit. Most patch authors won't know about using
> -DWRITE_READ_PARSE_PLAN_TREES etc, so they won't even think about enabli=
ng
> them. We're *really* not doing well on the "timely review" side of thing=
s, so
> we at least should not waste time on high latency back-forth for easily
> automatically detectable things.

I don't personally have an objection to either of those; maybe Robert
does.

			regards, tom lane