From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ryan Lambert <ryan@rustprooflabs.com>
cc: pgsql-hackers@lists.postgresql.org,
        Pavel Stehule <pavel.stehule@gmail.com>,
        Chapman Flack <chap@anastigmatix.net>
Subject: Re: Fix XML handling with DOCTYPE
In-reply-to: 
 <155365077718.16480.16818772077198550388.pgcf@coridan.postgresql.org>
References: 
 <CAN-V+g-6JqUQEQZ55Q3toXEN6d5Ez5uvzL4VR+8KtvJKj31taw@mail.gmail.com>
 <15786.1553639496@sss.pgh.pa.us>
 <155365077718.16480.16818772077198550388.pgcf@coridan.postgresql.org>
Comments: In-reply-to Ryan Lambert <ryan@rustprooflabs.com>
	message dated "Wed, 27 Mar 2019 01:39:37 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <27244.1553658733.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 26 Mar 2019 23:52:13 -0400
Message-ID: <27245.1553658733@sss.pgh.pa.us>
Precedence: bulk

Ryan Lambert <ryan@rustprooflabs.com> writes:
> I have two recommendations for features.sgml.  You state: =


>> relies on the libxml library

> Should this be clarified as the libxml2 library?  That's what I installe=
d to build postgres from source (Ubuntu 16/18).  If it is the libxml libra=
ry and the "2" is irrelevant, or it it works with either, it might be nice=
 to have a clarifying note to indicate that.

Do we need to mention that at all?  If you're not building from source,
it doesn't seem very interesting ... but maybe I'm missing some reason
why end users would care.

> It seems you are standardizing from "node set" to "nodeset", is that the=
 preferred nomenclature or preference?

That seemed a bit jargon-y to me too.  If that's standard terminology
in the XML world, maybe it's fine; but I'd have stuck with "node set".

			regards, tom lane