From: Tom Lane <tgl@sss.pgh.pa.us>
To: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
cc: "Tristan Partin" <tristan@neon.tech>,
        "pgsql-hackers" <pgsql-hackers@postgresql.org>
Subject: Re: On non-Windows, hard depend on uselocale(3)
In-reply-to: <87y1eyn9ig.fsf@wibble.ilmari.org>
References: <CWZBBRR6YA8D.8EHMDRGLCKCD@neon.tech> <2689177.1700070346@sss.pgh.pa.us> <87y1eyn9ig.fsf@wibble.ilmari.org>
Comments: In-reply-to =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
	message dated "Wed, 15 Nov 2023 18:42:31 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2733240.1700075043.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 15 Nov 2023 14:04:03 -0500
Message-ID: <2733241.1700075043@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2733241.1700075043%40sss.pgh.pa.us>
Precedence: bulk

=3D?utf-8?Q?Dagfinn_Ilmari_Manns=3DC3=3DA5ker?=3D <ilmari@ilmari.org> writ=
es:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> "Tristan Partin" <tristan@neon.tech> writes:
>>> I would like to propose removing HAVE_USELOCALE, and just have WIN32, =

>>> which means that Postgres would require uselocale(3) on anything that =

>>> isn't WIN32.

>> You would need to do some research and try to prove that that won't
>> be a problem on any modern platform.  Presumably it once was a problem,
>> or we'd not have bothered with a configure check.

> For reference, the Perl effort to use the POSIX.1-2008 thread-safe
> locale APIs have revealed several platform-specific bugs that cause it
> to disable them on FreeBSD and macOS:
> https://github.com/perl/perl5/commit/9cbc12c368981c56d4d8e40cc9417ac26be=
c2c35
> https://github.com/perl/perl5/commit/dd4eb78c55aab441aec1639b1dd49f88bd9=
60831
> and work around bugs on others (e.g. OpenBSD):
> https://github.com/perl/perl5/commit/0f3830f3997cf7ef1531bad26d2e0f13220=
dd862
> But Perl actually makes use of per-thread locales, because it has a
> separate interpereer per thread, each of which can have a different
> locale active.  Since Postgres isn't actually multi-threaded (yet),
> these concerns might not apply to the same degree.

Interesting.  That need not stop us from dropping the configure
check for uselocale(), but it might be a problem for Tristan's
larger ambitions.

			regards, tom lane