Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cUyEI-0000dT-Nh for pgsql-hackers@arkaria.postgresql.org; Sat, 21 Jan 2017 16:09:26 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cUyEH-0007xD-1p for pgsql-hackers@arkaria.postgresql.org; Sat, 21 Jan 2017 16:09:25 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cUyEA-0007s7-L6 for pgsql-hackers@postgresql.org; Sat, 21 Jan 2017 16:09:18 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cUyE8-00071y-27 for pgsql-hackers@postgresql.org; Sat, 21 Jan 2017 16:09:17 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v0LG9EWk027448; Sat, 21 Jan 2017 11:09:14 -0500 From: Tom Lane To: Pavan Deolasee cc: Alvaro Herrera , pgsql-hackers Subject: Re: Failure in commit_ts tap tests In-reply-to: References: <20170120182702.tjjk2mh3t5keansh@alvherre.pgsql> <21212.1484939708@sss.pgh.pa.us> <26339.1485013196@sss.pgh.pa.us> Comments: In-reply-to Pavan Deolasee message dated "Sat, 21 Jan 2017 21:32:43 +0530" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <27446.1485014954.1@sss.pgh.pa.us> Date: Sat, 21 Jan 2017 11:09:14 -0500 Message-ID: <27447.1485014954@sss.pgh.pa.us> X-Pg-Spam-Score: -5.1 (-----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Pavan Deolasee writes: > On Sat, Jan 21, 2017 at 9:09 PM, Tom Lane wrote: >> Hm, but what of the "null" value? Also, I get >> >> $ perl -e 'use warnings; use Test::More; ok("2017-01-01" != "null", "ok");' >> Argument "null" isn't numeric in numeric ne (!=) at -e line 1. >> Argument "2017-01-01" isn't numeric in numeric ne (!=) at -e line 1. >> ok 1 - ok > It declares the test as "passed", right? Oh! So it does. That is one darn weird behavior of the != operator. > I am not saying that's a correct > behaviour, but that's why we didn't catch the problem earlier. Check. Mystery solved. There's still the point that we're not actually exercising this script in the buildfarm ... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers