Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k45f4-0004aO-Ht for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Aug 2020 16:56:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k45f3-0001TN-FS for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Aug 2020 16:56:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k45f3-0001TG-8h for pgsql-hackers@lists.postgresql.org; Fri, 07 Aug 2020 16:56:05 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k45f1-0007zl-7L for pgsql-hackers@postgresql.org; Fri, 07 Aug 2020 16:56:04 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 077Gu1oe2758175; Fri, 7 Aug 2020 12:56:01 -0400 From: Tom Lane To: Robert Haas cc: Bharath Rupireddy , PostgreSQL-development Subject: Re: Parallel worker hangs while handling errors. In-reply-to: References: <2754818.1596814605@sss.pgh.pa.us> Comments: In-reply-to Robert Haas message dated "Fri, 07 Aug 2020 12:13:55 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2758173.1596819361.1@sss.pgh.pa.us> Date: Fri, 07 Aug 2020 12:56:01 -0400 Message-ID: <2758174.1596819361@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Robert Haas writes: > On Fri, Aug 7, 2020 at 11:36 AM Tom Lane wrote: >> The sigdelset call, just like the adjacent pqsignal calls, is >> preparatory setup; it does not intend to allow anything to happen >> immediately. > I don't think that your analysis here is correct. The sigdelset call > is manipulating BlockSig, and the subsequent PG_SETMASK call is > working with UnblockSig, so it doesn't make sense to view one as a > preparatory step for the other. That SETMASK call will certainly unblock SIGQUIT, so I don't see what your point is. Anyway, the bottom line is that that code's been like that for a decade or two without complaints, so I'm disinclined to mess with it on the strength of nothing much. regards, tom lane