Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: bufmgr: pass through I/O stats context in FlushUnlockedBuffer()
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAAKRu_aUfeVKFW34ZvuhY9tBXUKYfn8rs-8cf-aE4YSUFj-xEQ@mail.gmail.com>
Date: Wed, 22 Apr 2026 06:24:04 +0800
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Andres Freund <andres@anarazel.de>
Content-Transfer-Encoding: quoted-printable
Message-Id: <275CB553-A9F6-4C4D-92FD-78DCC139205F@gmail.com>
References: <BC97546F-5C15-42F2-AD57-CFACDB9657D0@gmail.com>
 <CAAKRu_aUfeVKFW34ZvuhY9tBXUKYfn8rs-8cf-aE4YSUFj-xEQ@mail.gmail.com>
To: Melanie Plageman <melanieplageman@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/275CB553-A9F6-4C4D-92FD-78DCC139205F%40gmail.com>
Precedence: bulk


> On Apr 22, 2026, at 05:52, Melanie Plageman =
<melanieplageman@gmail.com> wrote:
>=20
> On Tue, Mar 31, 2026 at 10:15=E2=80=AFPM Chao Li =
<li.evan.chao@gmail.com> wrote:
>>=20
>> I noticed that FlushUnlockedBuffer() accepts io_object and =
io_context, but then ignores them and hardcodes IOOBJECT_RELATIONand =
IOCONTEXT_NORMAL instead:
>> ```
>> static void
>> FlushUnlockedBuffer(BufferDesc *buf, SMgrRelation reln,
>>                                        IOObject io_object, IOContext =
io_context)
>> {
>>        Buffer          buffer =3D BufferDescriptorGetBuffer(buf);
>>=20
>>        BufferLockAcquire(buffer, buf, BUFFER_LOCK_SHARE_EXCLUSIVE);
>>        FlushBuffer(buf, reln, IOOBJECT_RELATION, IOCONTEXT_NORMAL); =
// <=3D=3D HERE
>>        BufferLockUnlock(buffer, buf);
>> }
>> ```
>>=20
>> Unless I am missing something, if a function accepts these =
parameters, they should generally be used.
>=20
> Thanks for the patch. Committed in 31b0544b32b
>=20
> - Melanie

Hi Melanie, thank you very much for pushing.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/