Feedback-ID: i131946ab:Fastmail
Message-ID: <275c47ea-e7f3-e654-c99a-63bc116997d7@enterprisedb.com>
Date: Mon, 22 May 2023 14:34:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.1
Subject: Re: Order changes in PG16 since ICU introduction
Content-Language: en-US
To: Jeff Davis <pgsql@j-davis.com>, "Jonathan S. Katz"
 <jkatz@postgresql.org>, Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Regina Obe <lr@pcorp.us>,
 Sandro Santilli <strk@kbt.io>, pgsql-hackers@lists.postgresql.org
References: <000b01d97465$c34bbd60$49e33820$@pcorp.us>
 <3353947.1682092131@sss.pgh.pa.us> <ZELDOktA75yYG4Z2@hst.kbt.io>
 <533d93c5-f604-8e5f-4a48-975c08c53d59@enterprisedb.com>
 <3365333.1682098091@sss.pgh.pa.us> <002d01d97477$f0395640$d0ac02c0$@pcorp.us>
 <3367226.1682099185@sss.pgh.pa.us> <003b01d9747a$910471c0$b30d5540$@pcorp.us>
 <3368986.1682099982@sss.pgh.pa.us> <000001d9747d$066b7560$13426020$@pcorp.us>
 <3372735.1682101425@sss.pgh.pa.us>
 <f83f089ee1e9acd5dbbbf3353294d24e1f196e95.camel@j-davis.com>
 <CA+TgmobxgvonJT8vO_v0k9_rgDmn0CKvTe48Z=w95rrBqC95KA@mail.gmail.com>
 <7ee07b7d5aa4fb0b47e5657640568fdd25ba168f.camel@j-davis.com>
 <CA+TgmoaPGx+R6mOcYQwDfqGoZxd=SncDCDt9mYjz5AD5tFd8sw@mail.gmail.com>
 <2ffe8ffb9291b9390b9ed6c1e34b4fae8e8ce324.camel@j-davis.com>
 <25787ec7-4c04-9a8a-d241-4dc9be0b1ba3@postgresql.org>
 <605324592391599a7ecd522087edbd00720793b7.camel@j-davis.com>
 <f353900f4c5777b02e9c7ef85326f1954ffeccea.camel@j-davis.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <f353900f4c5777b02e9c7ef85326f1954ffeccea.camel@j-davis.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/275c47ea-e7f3-e654-c99a-63bc116997d7%40enterprisedb.com>
Precedence: bulk

On 18.05.23 00:59, Jeff Davis wrote:
> On Tue, 2023-05-16 at 20:23 -0700, Jeff Davis wrote:
>> Other than that, and I took your suggestions almost verbatim. Patch
>> attached. Thank you!
> 
> Attached new patch with a typo fix and a few other edits. I plan to
> commit soon.

Some small follow-up on this patch:

Please put blank lines between

</sect3>
<sect3 ...>

etc., matching existing style.

We usually don't capitalize the collation parameters like

CREATE COLLATION mycollation1 (PROVIDER = icu, LOCALE = 'ja-JP);

elsewhere in the documentation.

Table 24.2. ICU Collation Settings should probably be sorted by key, or 
at least by something.

All tables should referenced in the text, like "Table x.y shows this and 
that."  (Note that a table could float to a different page in some 
output formats, so just putting it into a section without some 
introductory text isn't sound.)

Table 24.1. ICU Collation Levels shows punctuation as level 4, which is 
only true in shifted mode, which isn't the default.  The whole business 
of treating variable collation elements is getting a bit lost in this 
description.  The kv option is described as "Classes of characters 
ignored during comparison at level 3.", which is effectively true but 
not the whole picture.