Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k46fg-00076O-2S for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Aug 2020 18:00:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k46fe-0004SE-1r for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Aug 2020 18:00:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k46fd-0004S6-Qp for pgsql-hackers@lists.postgresql.org; Fri, 07 Aug 2020 18:00:45 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k46fW-00005X-KL for pgsql-hackers@postgresql.org; Fri, 07 Aug 2020 18:00:45 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 077I0Yd22764321; Fri, 7 Aug 2020 14:00:34 -0400 From: Tom Lane To: Robert Haas cc: Bharath Rupireddy , PostgreSQL-development Subject: Re: Parallel worker hangs while handling errors. In-reply-to: References: <2754818.1596814605@sss.pgh.pa.us> <2758174.1596819361@sss.pgh.pa.us> Comments: In-reply-to Robert Haas message dated "Fri, 07 Aug 2020 13:37:59 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2764319.1596823234.1@sss.pgh.pa.us> Date: Fri, 07 Aug 2020 14:00:34 -0400 Message-ID: <2764320.1596823234@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Robert Haas writes: > On Fri, Aug 7, 2020 at 12:56 PM Tom Lane wrote: >> That SETMASK call will certainly unblock SIGQUIT, so I don't see what >> your point is. > I can't figure out if you're trolling me here or what. It's true that > the PG_SETMASK() call will certainly unblock SIGQUIT, but that would > also be true if the sigdelset() call were absent. The point of the sigdelset is that if somewhere later on, we install the BlockSig mask, then SIGQUIT will remain unblocked. You asserted upthread that noplace in these processes ever does so; maybe that's true today, or maybe not, but the intent of this code is that *once we get through initialization* SIGQUIT will remain unblocked. I'll concede that it's not 100% clear whether or not these processes need to re-block SIGQUIT during error recovery. I repeat, though, that I'm disinclined to change that without some evidence that there's actually a problem with the way it works now. regards, tom lane