Message-ID: <2765f538-b06f-4e57-bcb2-9ca1dc6f487d@pgbackrest.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Fix logging for invalid recovery timeline
To: =?UTF-8?Q?Benoit_Lobr=C3=A9au?= <benoit.lobreau@dalibo.com>,
 "Andrey M. Borodin" <x4mmm@yandex-team.ru>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
References: <c3d617d4-1696-4aa7-8a4d-5a7d19cc5618@pgbackrest.org>
 <C748635E-B2FF-4813-B035-AE670832B9FD@yandex-team.ru>
 <d0b27c08-d30f-4a1d-990d-5c90ca0a650a@pgbackrest.org>
 <4ed10bc8-5513-4d8e-8643-8abcaa08336d@dalibo.com>
Content-Language: en-US
From: David Steele <david@pgbackrest.org>
In-Reply-To: <4ed10bc8-5513-4d8e-8643-8abcaa08336d@dalibo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Date: Wed, 19 Feb 2025 17:35:18 +0000 (UTC)
Archived-At: 
 <https://www.postgresql.org/message-id/2765f538-b06f-4e57-bcb2-9ca1dc6f487d%40pgbackrest.org>
Precedence: bulk

On 2/19/25 03:51, Benoit Lobréau wrote:
> 
> I think the changes make sense. Would it be helpful to add the origin of 
> the checkpoint record we are referring to ? (i.e. control file or backup 
> label).
> 
> For example:
> 
> * Latest checkpoint in the control file is at %X/%X on timeline %u,
> * Checkpoint location in the backup_label file is at %X/%X on timeline %u,

I like this idea but I would prefer to get the patch committed as-is 
first. The reason is that I'm hoping to see this batch-patched (since it 
is a bug) and that is less likely if the message wording is change.

Your idea would be perfect going forward, though.

Regards,
-David