From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tatsuo Ishii <ishii@sraoss.co.jp>
cc: nagata@sraoss.co.jp, coelho@cri.ensmp.fr, thomas.munro@gmail.com,
        m.polyakova@postgrespro.ru, alvherre@2ndquadrant.com,
        pgsql-hackers@postgresql.org, teodor@sigaev.ru
Subject: Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors
In-reply-to: <20220323.190809.88053056758099179.t-ishii@sranhm.sra.co.jp>
References: <20220322090815.2b59ff5139c666f25312c337@sraoss.co.jp>
 <20220322172714.7ac718269598b7d52b009dd7@sraoss.co.jp>
 <20220322.184415.118632931744953435.t-ishii@sranhm.sra.co.jp>
 <20220323.190809.88053056758099179.t-ishii@sranhm.sra.co.jp>
Comments: In-reply-to Tatsuo Ishii <ishii@sraoss.co.jp>
	message dated "Wed, 23 Mar 2022 19:08:09 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2775988.1648060014.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 23 Mar 2022 14:26:54 -0400
Message-ID: <2775989.1648060014@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2775989.1648060014%40sss.pgh.pa.us>
Precedence: bulk

Tatsuo Ishii <ishii@sraoss.co.jp> writes:
> The patch Pushed. Thank you!

My hoary animal prairiedog doesn't like this [1]:

#   Failed test 'concurrent update with retrying stderr /(?s-xim:client (0=
|1) got an error in command 3 \\(SQL\\) of script 0; ERROR:  could not ser=
ialize access due to concurrent update\\b.*\\g1)/'
#   at t/001_pgbench_with_server.pl line 1229.
#                   'pgbench: pghost: /tmp/nhghgwAoki pgport: 58259 nclien=
ts: 2 nxacts: 1 dbName: postgres
...
# pgbench: client 0 got an error in command 3 (SQL) of script 0; ERROR:  c=
ould not serialize access due to concurrent update
...
# '
#     doesn't match '(?s-xim:client (0|1) got an error in command 3 \\(SQL=
\\) of script 0; ERROR:  could not serialize access due to concurrent upda=
te\\b.*\\g1)'
# Looks like you failed 1 test of 425.

I'm not sure what the "\\b.*\\g1" part of this regex is meant to
accomplish, but it seems to be assuming more than it should
about the output format of TAP messages.

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dprairiedog&d=
t=3D2022-03-23%2013%3A21%3A44