From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@postgresql.org, Justin Pryzby <pryzby@telsasoft.com>
Subject: Re: what should install-world do when docs are not available?
In-reply-to: <20230325201414.sh7c6xlut2fpunnv@awork3.anarazel.de>
References: <20230325201414.sh7c6xlut2fpunnv@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sat, 25 Mar 2023 13:14:14 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2779988.1679776803.1@sss.pgh.pa.us>
Date: Sat, 25 Mar 2023 16:40:03 -0400
Message-ID: <2779989.1679776803@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2779989.1679776803%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> Right now if one does install-world with autoconf, without having xmllint or
> xsltproc available, one gets an error:
> ERROR: `xmllint' is missing on your system.

> Is that good? Should meson behave the same?

Since install-world is defined to install documentation, it should
do so or fail trying.  Maybe we could skip the xmllint step, but you'd
still need xsltproc so I'm not sure that that moves the bar very far.

> If that's what we decide to do, perhaps "docs" should be split further? The
> dependencies for pdf generation are a lot more heavyweight.

Yeah.  Personally I think "docs" should just build/install the HTML
docs, but maybe I'm too narrow-minded.

> We should probably also generate a useful error when the stylesheets aren't
> available.

Maybe, but we haven't had that in the autoconf case either, and there
have not been too many complaints.  Not sure it's worth putting extra
effort into.

			regards, tom lane