From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Thomas Munro <thomas.munro@gmail.com>,
 Fabien COELHO <coelho@cri.ensmp.fr>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        David Steele <david@pgmasters.net>,
 Andres Freund <andres@anarazel.de>,
        Noah Misch <noah@leadboat.com>, Stephen Frost <sfrost@snowman.net>,
        Amit Kapila <amit.kapila16@gmail.com>,
        Suraj Kharage <suraj.kharage@enterprisedb.com>,
        tushar <tushar.ahuja@enterprisedb.com>,
        Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>,
        Rushabh Lathia <rushabh.lathia@gmail.com>,
        Tels <nospam-pg-abuse@bloodgate.com>,
        Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
        Jeevan Chalke <jeevan.chalke@enterprisedb.com>,
        vignesh C <vignesh21@gmail.com>
Subject: Re: backup manifests and contemporaneous buildfarm failures
In-reply-to: <26044.1585954081@sss.pgh.pa.us>
References: 
 <CA+TgmoazJ5wh+H77kjVfMnDh6WLh=oJodrwJ21SACSq5fojwPg@mail.gmail.com>
 <20200403205412.GA8279@alvherre.pgsql>
 <CA+TgmoaRbm-L1C2YkDVPx1TGN9ufxWjnaweTwKE=TQC-YOD=rg@mail.gmail.com>
 <CA+TgmoZ4bAbjd_Am=UiMpBrgPEO=7YarqvaAMrQYKP1GkkOaRg@mail.gmail.com>
 <alpine.DEB.2.21.2004032346550.16227@pseudo> <22394.1585951968@sss.pgh.pa.us>
 <CA+hUKGLpHXW5AyKEXV+=8iheyZD89+vR6OXOvzdvhwFmyvQwpQ@mail.gmail.com>
 <26044.1585954081@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Fri, 03 Apr 2020 18:48:01 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <27801.1585954933.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 03 Apr 2020 19:02:13 -0400
Message-ID: <27802.1585954933@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> I'm guessing that we're looking at a platform-specific difference in
> whether "rm -rf" fails outright on an unreadable subdirectory, or
> just tries to carry on by unlinking it anyway.

Yeah... on my RHEL6 box, "make check" cleans up the working directories
under tmp_check, but on a FreeBSD 12.1 box, not so much: I'm left with

$ ls tmp_check/
log/                            t_003_corruption_master_data/
tgl@oldmini$ ls -R tmp_check/t_003_corruption_master_data/
backup/

tmp_check/t_003_corruption_master_data/backup:
open_directory_fails/

tmp_check/t_003_corruption_master_data/backup/open_directory_fails:
pg_subtrans/

tmp_check/t_003_corruption_master_data/backup/open_directory_fails/pg_subt=
rans:
ls: tmp_check/t_003_corruption_master_data/backup/open_directory_fails/pg_=
subtrans: Permission denied

I did not see any complaints printed to the terminal, but in
regress_log_003_corruption there's

...
ok 40 - corrupt backup fails validation: open_directory_fails: matches
cannot chdir to child for /usr/home/tgl/pgsql/src/bin/pg_validatebackup/tm=
p_check/t_003_corruption_master_data/backup/open_directory_fails/pg_subtra=
ns: Permission denied at t/003_corruption.pl line 126.
cannot remove directory for /usr/home/tgl/pgsql/src/bin/pg_validatebackup/=
tmp_check/t_003_corruption_master_data/backup/open_directory_fails: Direct=
ory not empty at t/003_corruption.pl line 126.
# Running: pg_basebackup -D /usr/home/tgl/pgsql/src/bin/pg_validatebackup/=
tmp_check/t_003_corruption_master_data/backup/search_directory_fails --no-=
sync -T /tmp/lxaL_sLcnr=3D/tmp/_fegwVjoDR
ok 41 - base backup ok
...

This may be more of a Perl version issue than a platform issue,
but either way it's a problem.

Also, on the FreeBSD box, "rm -rf" isn't happy either:

$ rm -rf tmp_check
rm: tmp_check/t_003_corruption_master_data/backup/open_directory_fails/pg_=
subtrans: Permission denied
rm: tmp_check/t_003_corruption_master_data/backup/open_directory_fails: Di=
rectory not empty
rm: tmp_check/t_003_corruption_master_data/backup: Directory not empty
rm: tmp_check/t_003_corruption_master_data: Directory not empty
rm: tmp_check: Directory not empty


			regards, tom lane