From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Melih Mutlu <m.melihmutlu@gmail.com>,
        Thomas Munro <thomas.munro@gmail.com>,
        "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: wake up logical workers after ALTER SUBSCRIPTION
In-reply-to: <20221214183759.GC773264@nathanxps13>
References: 
 <CAGPVpCTkdaOyBLXB435VXq0RA1cHLFQut7BPm6t8D4dsdiEXZQ@mail.gmail.com>
 <20221207181145.GA3698731@nathanxps13> <2550453.1670974328@sss.pgh.pa.us>
 <20221214000145.GA638663@nathanxps13> <2561155.1670977214@sss.pgh.pa.us>
 <20221214004105.GA669835@nathanxps13> <20221214171023.GA689106@nathanxps13>
 <2707695.1671039752@sss.pgh.pa.us> <20221214174535.GA773264@nathanxps13>
 <2783450.1671042198@sss.pgh.pa.us> <20221214183759.GC773264@nathanxps13>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Wed, 14 Dec 2022 10:37:59 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2787770.1671044578.1@sss.pgh.pa.us>
Date: Wed, 14 Dec 2022 14:02:58 -0500
Message-ID: <2787771.1671044578@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2787771.1671044578%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Wed, Dec 14, 2022 at 01:23:18PM -0500, Tom Lane wrote:
>> Oh.  What in the world is the rationale for that?

> My assumption is that this is meant to avoid starting workers as fast as
> possible if they repeatedly crash.

I can see the point of rate-limiting if the workers are failing to connect
or crashing while trying to process data.  But it's not very sane to
apply the same policy to an intentional worker exit-for-reconfiguration.

Maybe we could have workers that are exiting for that reason set a
flag saying "please restart me without delay"?

A *real* fix would be to not exit at all, at least for reconfigurations
that don't change the connection parameters, but instead cope with
recomputing whatever needs recomputed in the workers' state.  I can
believe that that'd be a lot of work though.

			regards, tom lane