From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@postgreSQL.org
Subject: Garbled comment in postgresGetForeignJoinPaths
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <27896.1502901074.1@sss.pgh.pa.us>
Date: Wed, 16 Aug 2017 12:31:14 -0400
Message-ID: <27897.1502901074@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

postgres_fdw.c around line 4500:

    /*
     * If there is a possibility that EvalPlanQual will be executed, we need
     * to be able to reconstruct the row using scans of the base relations.
     * GetExistingLocalJoinPath will find a suitable path for this purpose in
     * the path list of the joinrel, if one exists.  We must be careful to
     * call it before adding any ForeignPath, since the ForeignPath might
     * dominate the only suitable local path available.  We also do it before
-->  * reconstruct the row for EvalPlanQual(). Find an alternative local path
     * calling foreign_join_ok(), since that function updates fpinfo and marks
     * it as pushable if the join is found to be pushable.
     */

Should the marked line simply be deleted?  If not, what correction is
appropriate?

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers