Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOnTL-0007Lf-LY for pgsql-hackers@arkaria.postgresql.org; Thu, 09 May 2019 18:08:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hOnTI-00055i-V5 for pgsql-hackers@arkaria.postgresql.org; Thu, 09 May 2019 18:08:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOnTI-00055b-Iy for pgsql-hackers@lists.postgresql.org; Thu, 09 May 2019 18:08:44 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOnTF-0000Gw-T6 for pgsql-hackers@lists.postgresql.org; Thu, 09 May 2019 18:08:42 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x49I8d3i027917; Thu, 9 May 2019 14:08:39 -0400 From: Tom Lane To: Michael Paquier cc: pgsql-hackers@lists.postgresql.org Subject: Re: Inconsistent error message wording for REINDEX CONCURRENTLY In-reply-to: <20190509041154.GC14573@paquier.xyz> References: <20190504085543.GE2174@paquier.xyz> <4469.1556982011@sss.pgh.pa.us> <20190505141645.GA7392@paquier.xyz> <16468.1557077559@sss.pgh.pa.us> <21697.1557092753@sss.pgh.pa.us> <2321.1557263978@sss.pgh.pa.us> <20190508075853.GC1602@paquier.xyz> <21629.1557318714@sss.pgh.pa.us> <20190508130538.GB3712@paquier.xyz> <14251.1557372515@sss.pgh.pa.us> <20190509041154.GC14573@paquier.xyz> Comments: In-reply-to Michael Paquier message dated "Thu, 09 May 2019 13:11:54 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <27915.1557425319.1@sss.pgh.pa.us> Date: Thu, 09 May 2019 14:08:39 -0400 Message-ID: <27916.1557425319@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Michael Paquier writes: > On Wed, May 08, 2019 at 11:28:35PM -0400, Tom Lane wrote: >> Pushed my stuff, have at it. > Thanks. Attached is what I get to after scanning the error messages > in indexcmds.c and index.c. Perhaps you have more comments about it? LGTM, thanks. regards, tom lane