From: Sergei Kornilov <sk@zsrv.org>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: "michael.paquier@gmail.com" <michael.paquier@gmail.com>,
	"andres@anarazel.de" <andres@anarazel.de>,
	"peter.eisentraut@2ndquadrant.com" <peter.eisentraut@2ndquadrant.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
In-Reply-To: <20180111.155910.26212237.horiguchi.kyotaro@lab.ntt.co.jp>
References: 
 <CAB7nPqS4bhSsDm_47GVjQno=iU6thx13MQVwwXXKBHQwfwwNCA@mail.gmail.com>
	<20171222.150320.244267360.horiguchi.kyotaro@lab.ntt.co.jp>
	<337571513944260@web55j.yandex.ru>
 <20180111.155910.26212237.horiguchi.kyotaro@lab.ntt.co.jp>
Subject: Re: [HACKERS] Restricting maximum keep segments by repslots
MIME-Version: 1.0
Message-Id: <2798121515664527@web40g.yandex.ru>
Date: Thu, 11 Jan 2018 12:55:27 +0300
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
Precedence: bulk

Hello

>>  patch -p1 gives some "Stripping trailing CRs from patch"
>>  messages for me, but applied to current HEAD and builds. After
>
> Hmm. I wonder why I get that complaint so often. (It's rather
> common? or caused by the MIME format of my mail?) I'd say with
> confidence that it is because you retrieved the patch file on
> Windows mailer.
I use Debian and web based mailer. Hm, i wget patches from links here https://www.postgresql.org/message-id/flat/20180111.155910.26212237.horiguchi.kyotaro%40lab.ntt.co.jp - applies clean both last and previous messages. Its strange.

Updated patches builds ok, but i found one failed test in make check-world: contrib/test_decoding/sql/ddl.sql at the end makes SELECT * FROM pg_replication_slots; which result of course was changed
And i still have no better ideas for naming. I think on something like
if (min_keep_lsn <= restart_lsn)
	if (active_pid != 0) 
		status = "streaming";
	else 
		status = "keeping";
else
	status = "may_lost";
This duplicates an existing active field, but I think it's useful as slot status description.
wal_status streaming/keeping/lost/unknown as described in docs patch is also acceptable for me. Maybe anyone else has better idea?

Regards, Sergei